Subject: Re: [PATCH v6 14/17] powerpc: Add support for setting SPRN_TIDR
From: Benjamin Herrenschmidt <benh@au1.ibm.com>
Reply-To: benh@au1.ibm.com
To: Michael Neuling <mikey@neuling.org>,
        Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>
Cc: stewart@linux.vnet.ibm.com, linuxppc-dev@ozlabs.org,
        linux-kernel@vger.kernel.org, apopple@au1.ibm.com, oohall@gmail.com
Date: Mon, 14 Aug 2017 23:30:35 +1000
In-Reply-To: <1502694131.9844.7.camel@neuling.org>
References: <1502233622-9330-1-git-send-email-sukadev@linux.vnet.ibm.com>
         <1502233622-9330-15-git-send-email-sukadev@linux.vnet.ibm.com>
         <1502694131.9844.7.camel@neuling.org>
Organization: IBM Australia
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Message-Id: <1502717435.4493.29.camel@au1.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 983
Lines: 25

On Mon, 2017-08-14 at 17:02 +1000, Michael Neuling wrote:
> > +/*
> > + * We need to assign an unique thread id to each thread in a process. This
> > + * thread id is intended to be used with the Fast Thread-wakeup (aka Core-
> > + * to-core wakeup) mechanism being implemented on top of Virtual Accelerator
> > + * Switchboard (VAS).
> > + *
> > + * To get a unique thread-id per process we could simply use task_pid_nr()
> > + * but the problem is that task_pid_nr() is not yet available for the thread
> > + * when copy_thread() is called. Fixing that would require changing more
> > + * intrusive arch-neutral code in code path in copy_process()?.
> > + *
> > + * Further, to assign unique thread ids within each process, we need an
> > + * atomic field (or an IDR) in task_struct, which again intrudes into the
> > + * arch-neutral code.
> 
> Really?
> 
> > + * So try to assign globally unique thraed ids for now.
> 
> Yuck!

Also CAPI has size limits for the TIDR afaik

Ben.