Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751785AbdHNNp7 (ORCPT ); Mon, 14 Aug 2017 09:45:59 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:50328 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbdHNNp6 (ORCPT ); Mon, 14 Aug 2017 09:45:58 -0400 From: Eugeniy Paltsev To: "p.zabel@pengutronix.de" CC: "linux-kernel@vger.kernel.org" , "alex.g@adaptrum.com" , "Eugeniy.Paltsev@synopsys.com" , "s.trumtrar@pengutronix.de" , "andre.przywara@arm.com" , "wens@csie.org" , "baoyou.xie@linaro.org" , "mcoquelin.stm32@gmail.com" , "dinguyen@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "alexandre.torgue@st.com" , "maxime.ripard@free-electrons.com" , "kernel@pengutronix.de" Subject: Re: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 Thread-Topic: [PATCH v2 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 Thread-Index: AQHTEqNIqkEn4LDER0uLZdoTDOu/bqJ/MFYAgAAJDwCABIcRgA== Date: Mon, 14 Aug 2017 13:45:47 +0000 Message-ID: <1502718347.2586.16.camel@synopsys.com> References: <20170811130618.3676-1-p.zabel@pengutronix.de> <20170811130618.3676-2-p.zabel@pengutronix.de> <1502469440.2310.27.camel@pengutronix.de> In-Reply-To: <1502469440.2310.27.camel@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.106] Content-Type: text/plain; charset="utf-8" Content-ID: <3F81E6E37C182447A501BD05B553DDDE@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7EDk4xJ004877 Content-Length: 962 Lines: 38 Hi Philipp, On Fri, 2017-08-11 at 18:37 +0200, Philipp Zabel wrote: > > > +struct reset_simple_devdata { > > > > > + bool inverted; > > > > > > +}; > > > + > > > +static const struct reset_simple_devdata reset_simple_inverted = > > > { > > > + .inverted = true, > > > > Hmm. I think it would be useful for new devices if there were have > > a way  > > to specify this in devicetree. > > This is a separate issue, and it should be discussed including the > device tree list. > > It could be as simple as a boolean "active-low;" property. But then > absence of that property would not mean active-high for existing > active-low drivers, which is confusing. > > It could also reuse the flags already defined in > dt-bindings/reset/ti-syscon.h and have some kind of >     reset-flags = ; > property. > > Suggestions welcome. > Imho, reset-type = ; looks good. --  Eugeniy Paltsev