Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdHNNvJ (ORCPT ); Mon, 14 Aug 2017 09:51:09 -0400 Received: from mail-dm3nam03on0047.outbound.protection.outlook.com ([104.47.41.47]:58528 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751030AbdHNNvG (ORCPT ); Mon, 14 Aug 2017 09:51:06 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; ffwll.ch; dkim=none (message not signed) header.d=none;ffwll.ch; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 2/2] video: fbdev: Enable Xilinx FB for ZynqMP To: Daniel Vetter , Michal Simek CC: Linus Walleij , "linux-kernel@vger.kernel.org" , "monstr@monstr.eu" , Benjamin Gaignard , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , Arnd Bergmann , "linux-fbdev@vger.kernel.org" , Krzysztof Kozlowski , Paul Burton References: <757d86d1-cca5-3a99-a371-a4c7e1c76f9b@xilinx.com> From: Michal Simek Message-ID: <994f5b9f-9ba7-ad80-84c4-de1edd9e56d0@xilinx.com> Date: Mon, 14 Aug 2017 15:50:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23256.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(24454002)(377454003)(189002)(199003)(5660300001)(50986999)(81166006)(65826007)(81156014)(106466001)(63266004)(7416002)(83506001)(8936002)(77096006)(2906002)(229853002)(2950100002)(54356999)(6666003)(33646002)(23676002)(230700001)(31686004)(76176999)(93886004)(54906002)(6306002)(31696002)(626005)(9786002)(6246003)(36756003)(4326008)(86362001)(65956001)(65806001)(189998001)(53546010)(966005)(47776003)(36386004)(8676002)(305945005)(478600001)(4001350100001)(64126003)(356003)(50466002)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR02MB2242;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT017;1:I3mywoZCAgjuIyPDfs3+3Lv49OZz7PH9L3RK1l556NaRZhAAIBfBlVuI8GLqS7gG0/ZAUPLtzT6aaT0RyFgExIHa884inYOiIIkuVWOxKvp+u83rAYeAij2gvuaSufcDiRLyvkLM17aAND2QRAnv9lcIbMhfvH/SbnQmdRyEnxMmnKimGfBBRCVMyRu+nKmeh5fRMMJfRzNxaJKjrDJulQJoE+eXHap8hNOv27pgnwD4wlNfaAGHkQ46LQg7Isi67Pa6NGnJbYNmmPbDsTFYdlrjPpqjw8dUtZz1EJVGUc2skiNqZBbNEs9OuwzJ2ReI/FVd+K/CCp4UhXXi3lggixjUieOUbdSP0Xc80WVlmDA7/wzmqvgW08/GnMUuaxnJh4ZCUA3ar+WPRYHnU6WzD8GCwEAvrcR8I9CmHmQhsPpbYH0sOJplUXHSQnRvnt6+tlwicaJOoqttdALls3u16cvEMplWLaoUsSQQAXIAo4TkKmrXxak07S1qbn+ghCKnjgFsQ/Ryu8CeP1n5ZWj5RZyn0x48XCU052fHbWFSObclg7l/SyZ9SrQnp2LFTdZisKvKlK1NLrbryKwp1YVOvJbk+61ZbI0VGQUk4S8TU3dHlXKGOLfRjD8yxgIXKCyaJre/IpjjQlkll2GYjGbB/PNYbY0ARgJlxlC34rPcZUJRyI0y7QCypv7R1wzKyXeIG9F67Uxmv1lkEMsnqI2RfT1+usD5Bd19yQTweMn622GhehPg9fGpT4cFES8/Y3y/OphjIylOagDx2ov3m1arkP6HYZzR6txtw9QK31kCbXT5uP96PnD3htDwA1H8bcoFOOnvsqsumajsBTkZvQyiAQ== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 698c6341-f119-4aee-0f2f-08d4e31b8176 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN6PR02MB2242; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2242;3:ehtrDmcYWpuGa3EwYJBLOMnRqq+5Vcy1seX1ZJk7HXhYoA+7EE74YakQTC9JO5B9CjvkvrMzxHy+0nJRa7YWHgGXVmZh8cpzudZPySPHGA2P0byoDsXjfbGnTaL6dcS133c+anp7fhKi3ErygMXZkcYrPbnDUkgjqfnagx19ZBppCsokZ44U/sQzM+RDe4KY7LmAEmwYYRu9/JN6Gn85+YbvniTRNx8fNjv4oepI2lIY7JXgAoqtNu898FjyWBsuN9WBRJQLsY2fjo7ZsX8qCgxqLByltdrm1Q8XtSkCdc1wgG+gpfxx+PzJiNVZ9EeSYGSU9/vqaC7fYWN7zdo1EzPK3zOxDeheGK6BP4z8LLs=;25:v00MssJM5xVA5qky/vDpP3YdOJGMI9nk0zv5wK/R+y7WKgFOEKXdLkhNxU+EibpKZ9KwTbz9VQCaVntn8NVf+K+I6CmQMP1Fp0CsH/u2qWxtaW6biL5LaFDJ350N1F3XgvSWxoRLWk0hA/z/nkqfMTg2PswwxfwqhFHSpWCSw21c2AIInGwjJWoonlmcghPmzbNTWfkZlTX8PMlWCTv5ELlG9dqSUepJ3hbi1LTphZw8QgbPye6zECPidpwFDl2+OB2iYb3qlCk+R6+7HLDRWCe3J5B2KNPNhwxbR6V/WKLth4KAQg7Pb9/+FDpFaiybxBRPgPWY3iLHNPqq+tHGog== X-MS-TrafficTypeDiagnostic: BN6PR02MB2242: X-LD-Processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2242;31:l5mU83TRqXRCOJdOf2EksTTcog1JVAiXWlCoPnvRNQaXudY5ggUZtXKhfRY6yvzXA8nh6XQELBE+sxXglGUBosVpsgZNiVK4MI66iFFAZtGyniuWxpEYiDgHNkuGQosLNptescKbSK9//9PGgKu0NuEuf9hZSN9nYkwdPmtpGgFAJx+w2Jj8wgFzo8PTggtJYcYSafOxZ3tzoCyK1grriP+7Znr63HWuLw0WPcyyCTM=;20:ANkQGndAoJfX0rsJptikaPuT3tb0rmXqsx3I1R0REYs9S894FDRZ3vot3KJjZye14PzaP9T2TZ/O6QXBtUIBkUzJwFfL6Hhyuil/D1Fie1mw2wlBG49FDcdFPMmoQWdoqBCiU0FUUWwiB6WeCoCDTtWBAghx5lO0j4S7fshjc+cUHZuKYGItg+j2zZ/S0eUSSok8sVS3bvyKEzusSew1N0RA0vnkcROrtcOfKEn9WffmNumYsfhWLUzqLCCgKcRBUYDi2xx0pUUrzhbt6lXQLz0UEeZ2d2d93oshZ3C2+yBFk4LXfGhxDmIrSuI1jeAbb2kn9PyUZVC4Mv6gxIn8Z3HN9Unlc5NpqnveZvQS9CuJt0lrEFrqnhIvLiIJVhnIFvFn76kB+cqcGjWO8+MYCpWejX2RXZgUvBHDtjEv9FsDAt7IcRuz12FOnoHkcrSRHeRqUjxC4dAPBG7f/hQDq3IBpV3WSs2rBAKWYUL7kl9VlbZ2g7OGXKeA1ykQb6YQ X-Exchange-Antispam-Report-Test: UriScan:(166708455590820)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(13016025)(13018025)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93004095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR02MB2242;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR02MB2242; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2242;4:1l8JTYth9GQLSq/01wlTlMk12i7oouxSandTydZqC3aNwtnFytibTSjHRa+xx4tBQvK8HBq5dQpFE268wtomUhJFU8s3wF5BC7rVu7bJARy7d/qWt6Ttc0Kqhr57M9dyKN6WQPuEmvfhkT02fUtjHHiPzQ5PrNaE54kMM9g+pTcPgfPdebnWZET3V8p6qQpglfjFSKo9ZX5ps7zfzG10M6+KNlsL1jPEjtaOHpGzJfi8xnqCrSFkBcL4FMI5//IWIXASjTMzwODJa8QkwkFITkGf4f5hRrWtygP4ngTJ5ANvbOsSuKRrFRZvWzmjnN8yS/U743zr4RzJUpE7Gkom6Q== X-Forefront-PRVS: 039975700A X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAyTUIyMjQyOzIzOjUyWUpSd2o4T0RoTUl3MGV2MHo2eW1RdXYw?= =?utf-8?B?cVhyL3VtL1ZJZGpZR1grOE1tM3NTVXZGTzdwam4xL3psK1BabVJESml1bk52?= =?utf-8?B?VWpxem1NV3dCeGtsa0hReUJnSTEvbG9mZ0syeTFjbUh4V2hxT1U3WTB0aUZQ?= =?utf-8?B?N3NYQ09WbnlUbk9DVHhhNnJrNkprRTkxczVvcm8zTmRKL25Oem93SlJlS3Fx?= =?utf-8?B?a1FJMEcvcEJOMzNnZ3A3b1U0cUdKR2dkaDRXamozMmFEaWgwdStTRmVRR3NC?= =?utf-8?B?aENkSWlhQ3pzRjkyOEU2TWdJbEplZnovTENzeUxMbGhGWHRFbDNSRmRxVlow?= =?utf-8?B?MzROYXpWRW1SNFhjem45a0VYLzkxNUtoRXdtcXhRYVVia0JWOEhTeFI5aC80?= =?utf-8?B?VkpmWTBSSFZ5ZC9lNHBsZWxrYWZGWVNMUytmSG1RM3BuZTNWVldqMHZTU3lZ?= =?utf-8?B?V0Y3UXFhU0luMy9yV2JZbHUrdU8yNWpLTGx6OTE0Y1BkQVJXdHU5NWI5V2t0?= =?utf-8?B?YjEwK1paQzlmMFgwRitEZkdPMnBmYTZkZ0JObHZCbXdlREJqV1VsUFZLcXdt?= =?utf-8?B?dFoyK1FLN24xYlZ3aHBuQmpMUlJnUUJJNUxrWE9WbGVPL29relpwc3Q1UEZS?= =?utf-8?B?V2dEMEdkM2tvREVCa0Z5VFJYWUpOSHJJSEJmMzhsWC9jZEllYWROZkdycXpT?= =?utf-8?B?Z3pIRnB4MUQxbTlCTDJFRGRITk5KM2czYjJ5WVFaQldCRnp3RWM0Y05lbnhT?= =?utf-8?B?YmIvY1RrSHJBcGVOSzJIK3RyeFYyVUM5TmZOYUhQYzg0UTJhMldOT00vSUV4?= =?utf-8?B?V1F5ZFpHTjhDTW1Fb1VsMFhEVlhrMVk3VW4rUmZSalRkQlRnOXlMeXMyd2lI?= =?utf-8?B?c21pdUk4RnBuRzJKUG12eVJ0alZZeG1XMGdCaWdkVE4wYmQ5OHptNGUrUDBs?= =?utf-8?B?Z0thNHA2WEVwNVBXZUhqQXVmbmhvUDhMdGEvSHFHeG9YaDdwcFI3MFdkNVJI?= =?utf-8?B?cnpmbEN3cmhDSG0rSlRDUEVvbjJQT0w1bGx4cWlqSnBCMk9MbTF5UzlNc1hs?= =?utf-8?B?R2N6K2cxaTFiTGltNkJDalBRYlhKNGViVkFjUlRQOXFuVEtWRFlHYU1nYWd4?= =?utf-8?B?eXBKQkEzS3VkSDFFVFo2V1NFY0RpR2FaRFBXTEJVR21OS1ZYR3d4NHNXTkxP?= =?utf-8?B?Um0yMlNEU3NwZmpRdHA1S3BDT0FUNVBqK1VDVnRDbVZybVNySmtZbWlqWC93?= =?utf-8?B?TkZVTlZ2MHJxK0ZmbHpIQ2JZRDFTZndKMXNXRE10ZTVXaFlNS1JkZndKdDBD?= =?utf-8?B?RUttaFJ1ZVU3R1lCeXJwM3E5UndSdHZkeHlVeEhIOTN2RWJqc1JaeUR5U3Nu?= =?utf-8?B?U0pCeUVCQTFHcVRWZnVDbWM5WElabnFlMnFvNkVzdFhsUERlalltdkV1dmJK?= =?utf-8?B?SEUySUlXV1VjN2RBNEthUkpKVUFsdjg2bTEvalRZcGNJQWRUd2NLR0xqZjcx?= =?utf-8?B?TEQyazlqUDFsWDB2clNjSkgvMTA4SFVyOXZQN0h2VHUrbmZvRmRWcEdpTE5N?= =?utf-8?B?Y2dmV1cwSHBlNjRXMW9BNXJISnczN1lRZnpwWDg2TlY1bXJrVy9hTUw4YjVD?= =?utf-8?B?b25QRUttOWZyUVREZFVSWWQwVGVFV3VCQlRocjJmVkhyR3lscytUSXZob1RZ?= =?utf-8?Q?DRATGmwqEPL56nvAYK9ewH15AexQJM9oSLNa4Bd?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2242;6:NcBqyh6OH0rv59Iv2tIOLfJVepdU0pWP/SppyQo+thJur5hKJBSoBO1N1V/bg7GLZng90bk3LUkjFfB9JwiTdwEsD7m3aqP4LhSj7RmfYiGPIpVTGE7qAjjV0sGNTS5qKbgp+S0oc3DVjK2NBnXDxG1zadqi05FwQQtMKlSnkAaTNoMZzvC94cMNgF5fkTAM/zyIRUrLdK4wMjcCELdi6cfgFOB5zI4raZTEsRAXkqSf/c6a+9hK76pHCW8SRs0D+QeEEvTX6VLGxqwtL2Md6qHxwlk2HZz8/Rfx2h05ZsQcKuF3OcZgvsOdunFZE5nQxPaLrXkXMevGA4fziyxfpA==;5:xo5LBEfEH8DEh76eYy6o7dKSmg5CVQ7JJ+5Im+xCndNZurfhXaS2Kqypr9+KxXNnXqBWqDYUX90rS8RrifAfU++0vWnT4Pw47QX3wyr5iXASSouoVtfkUFyOQNqFvoErW4CpeHnNiPhIytJvQGikiQ==;24:og196nUk6OngeWUD6eJRqc+/IBqmZ+N+mJhpGjbqQiQDq4Jd0+EBCNObszMRxpoO5zL9qzKm8ds/pJiG2ooxruTjVmrx2XlG/x56W5bNOBk=;7:Tkt34ekKC8btxrZSZPJWiAMq7ZjRtkjQ5v7wkplUIYQwdclMJwpu8e7UwcwsrlGGGsoa9UtZYtYGnmS9P4c1kYLA8DvEj0S46fkwFURhLhEviW3f3pGdEN7UwPVpMQAPyVO03gG1Uy2QlYRqWSkRFEh4VdDQ1Zn6tDRWByts0H23YytlfnagO0EjIaxQ4RmVjMS6k9sQk76sRpRboqHUDEwHoYYW+xXj6S56/KRrNdc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2017 13:51:03.7015 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2242 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 37 On 14.8.2017 15:49, Daniel Vetter wrote: > On Mon, Aug 14, 2017 at 3:46 PM, Michal Simek wrote: >> On 14.8.2017 15:42, Linus Walleij wrote: >>> On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek wrote: >>> >>>> Enable this driver for Xilinx ZynqMP. >>>> >>>> Signed-off-by: Michal Simek >>> >>> Not a comment on the patch per se, but I would advice you to look into >>> migrating the Xilinx frame buffer to DRI/DRM/KMS. >>> >>> The recent CMA helpers has made it very simple and focused to write >>> DRM drivers. See for example drivers/gpu/drm/pl111 >> >> There is a lot of work done by xilinx in this area gpu/drm/kms. I am >> trying to upstream what xilinx has in soc tree and this change is there. >> Maybe in this case it is useless and none is using it but it is there >> and I don't want to break user. There shouldn't be any technical problem >> to run this old fb driver in pl on arm64. > > A proper drm kms driver gives you backwards compat for fbdev for free. > And we're taking in patches to fill feature gaps in our fbdev > emulation as people hit them. There no reason nowadays at all to merge > new fbdev native drivers, your users will be taken care of by a drm > kms driver fully. You can look at xilinx work in this area. https://github.com/Xilinx/linux-xlnx Unfortunately they haven't started to upstream it. In this particular case I am not aware about anybody who is going to write new driver for this soft IP. Thanks, Michal