Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336AbdHNOMn (ORCPT ); Mon, 14 Aug 2017 10:12:43 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:38712 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdHNOMl (ORCPT ); Mon, 14 Aug 2017 10:12:41 -0400 Date: Mon, 14 Aug 2017 16:12:37 +0200 From: Daniel Vetter To: Arvind Yadav Cc: airlied@linux.ie, airlied@redhat.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: udl: constify usb_device_id Message-ID: <20170814141237.nkxzuligzp35ovyt@phenom.ffwll.local> Mail-Followup-To: Arvind Yadav , airlied@linux.ie, airlied@redhat.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <22fa8ca67a6d4a59997f463bf241ed56596fbcfa.1502526524.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22fa8ca67a6d4a59997f463bf241ed56596fbcfa.1502526524.git.arvind.yadav.cs@gmail.com> X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1363 Lines: 39 On Sat, Aug 12, 2017 at 02:05:19PM +0530, Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Applied, thanks. -Daniel > --- > drivers/gpu/drm/udl/udl_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c > index cd8b017..2877afc 100644 > --- a/drivers/gpu/drm/udl/udl_drv.c > +++ b/drivers/gpu/drm/udl/udl_drv.c > @@ -118,7 +118,7 @@ static void udl_usb_disconnect(struct usb_interface *interface) > * which is compatible with all known USB 2.0 era graphics chips and firmware, > * but allows DisplayLink to increment those for any future incompatible chips > */ > -static struct usb_device_id id_table[] = { > +static const struct usb_device_id id_table[] = { > {.idVendor = 0x17e9, .bInterfaceClass = 0xff, > .bInterfaceSubClass = 0x00, > .bInterfaceProtocol = 0x00, > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch