Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbdHNOT1 (ORCPT ); Mon, 14 Aug 2017 10:19:27 -0400 Received: from scorn.kernelslacker.org ([45.56.101.199]:36840 "EHLO scorn.kernelslacker.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdHNOT0 (ORCPT ); Mon, 14 Aug 2017 10:19:26 -0400 Date: Mon, 14 Aug 2017 10:19:24 -0400 From: Dave Jones To: Linux Kernel Mailing List Cc: James Smart , Christoph Hellwig Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return Message-ID: <20170814141924.sabddysk2bdg6vek@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Linux Kernel Mailing List , James Smart , Christoph Hellwig References: <20170811194419.4F5D82205C@pdx-korg-gitolite-1.ci.codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170811194419.4F5D82205C@pdx-korg-gitolite-1.ci.codeaurora.org> User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Note: SpamAssassin invocation failed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 804 Lines: 23 On Fri, Aug 11, 2017 at 07:44:19PM +0000, Linux Kernel wrote: > Web: https://git.kernel.org/torvalds/c/0fb228d30b8d72bfee51f57e638d412324d44a11 > Commit: 0fb228d30b8d72bfee51f57e638d412324d44a11 > Parent: 758f3735580c21b8a36d644128af6608120a1dde > Refname: refs/heads/master > Author: James Smart > AuthorDate: Tue Aug 1 15:12:39 2017 -0700 > Committer: Christoph Hellwig > CommitDate: Thu Aug 10 11:06:38 2017 +0200 > > nvmet_fc: add defer_req callback for deferment of cmd buffer return > + > + /* Cleanup defer'ed IOs in queue */ > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) { > + list_del(&deferfcp->req_list); > + kfree(deferfcp); > + } Shouldn't this be list_for_each_entry_safe ? Dave