Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbdHNOvs (ORCPT ); Mon, 14 Aug 2017 10:51:48 -0400 Received: from mail-co1nam03on0085.outbound.protection.outlook.com ([104.47.40.85]:63264 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751141AbdHNOvq (ORCPT ); Mon, 14 Aug 2017 10:51:46 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; roeck-us.net; dkim=none (message not signed) header.d=none;roeck-us.net; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters To: Guenter Roeck , Michal Simek CC: , , , Wim Van Sebroeck References: <6c3cef5b847f315f5fc1eb891b040e33719e88c7.1501832354.git.michal.simek@xilinx.com> <20170814144727.GB14491@roeck-us.net> From: Michal Simek Message-ID: <37041da3-51f2-95c4-1d98-c0732b6a5082@xilinx.com> Date: Mon, 14 Aug 2017 16:51:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170814144727.GB14491@roeck-us.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23256.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(199003)(24454002)(189002)(76104003)(478600001)(77096006)(31686004)(63266004)(50466002)(305945005)(50986999)(229853002)(8676002)(189998001)(76176999)(54356999)(36756003)(4001350100001)(2906002)(8936002)(36386004)(53546010)(65826007)(81166006)(81156014)(5660300001)(54906002)(106466001)(33646002)(86362001)(64126003)(230700001)(356003)(65806001)(47776003)(23676002)(2950100002)(6666003)(83506001)(4326008)(9786002)(31696002)(65956001)(626005)(6246003)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR02MB2250;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT030;1:or41xmjFzFFBVHN99Mx86AWNcmRNJ2gnNx/Zj2ZuKkGx+BYYbHuaZrkzj3J2sCZGSQJ9XgkGhtFRsqZkMAmY3U0xzeNQwjzUyzP7FT4P9hbuVb90AN32a8h51E1WpwmYWhwhH9ql9k4yrH3hdHb2nrysAmwLHBwZynqg4GywCBVgJNkSZS80h+V7+loDoQZZ447shsKjJdIE9FhlFdpNXDDbRhYeUK/uOkNkzdYAIH9n/WD/sz9oHxmNigcwH9vFSf2CR3/Ti+98IUFmPPaKZvgleVDduWLC8rjYTgRf4Oeoi9g0sNF5kfUY6Iqjj8L22iYpTj0IhXj3ZQDR93n7I8sg2FR67XT5cxQ1h2K7JK0msNp0qH8q0hgG7d4LHCyFS8t9A7L+WfYPMbDFzH/C7b/qhj0Hua9MSKXkYE1gWqBQFk0dvjKD3U9lZARYBeqbclvbtxvg+0sXOj3mRu51bQDBcnOYMXU2Pqhy4gkrYbIIoiuPyCBxpAAc817WULbACXnAskI9GWil3owjaifwHcl7RUKASLOJaB/sotPPGcDCMwt5cXRdlCvip1Ng1Pk0KAbCT2Mt0vVhCqAW91JVGOdIQeWPdgXytzLqlsP+WH8osXnp2W0krtBQpfIY+LRi2QDlNTt2P/P+/5i/dnSC+1QaEiVxD38NdLbo6MxvSTAcL4Ep4LMHpDXDAza8MqBHdUDmDCfSydp2a8vmXEQ+0Kdyea5V4CkqZTEjcyiYUxGQ3Q2tld8MRzVkWOlxVAr5hvort/ln97yGDMkJbaN0Cpf3ynlYPjPcqjOcD/ZLKZxhvnQoy+uuD10b3x+KUAegffx9J7iMyvpkUi9aS/v0fg== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db50bf1c-6d1e-41d3-d537-08d4e323fa9a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR02MB2250; X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2250;3:x3u7n2maPVfOrz3QgqVUchWZs/0zElPITBW4kpDfp7xwBiRYyymhNrxVv8vkl4BK3hLP1wVjtyU2QmNllfwrleYLSj128Hd7H/4bcnTpfwOl+XSrTY3T/t7VoNPe7cGF+yiivRk6mvssJsWN4+NaShZBtTxmxaFdvud49x2Pn98YR6wJ5n/2wolkWaxpfJsNqbBb9Rm27bUuCMRjKe40DZefBj53QV+g7bpW8gF9peF5lahbi53bKQmwNniKBSRUjH6ozHXD4+6zX7UbWyQeBQPTN3KLsAyTi7mWfkTr20HWgCNh3C0SZBXbRBsRe0fzj93+0YtLBp8lG5VE7nm6WMiiNEj9MXtjb25C2qF+z+8=;25:P2OR/Sr5IOi1+7geTu8H/3Ta9srM/l9x889rR+2b6WdpKthAOgRPNgYoYY4aFR0yZs6rISHT10YxBye6moqSaPOuqRHujnn7LIN2cdJ/m2Ax3R7wC1N5AuqYJVGNqJAFT1unhQge2zl0evAQtKjTxnixZOwiCRD0ttQmNIRiVOqI1FcZN+YAf5xsxSAAkEWj33PrZzWu6sWiU0ryG4Uf5U0kHiluAsYq3fNleOi+HiySQpGUqejA8JKUCwhNc1JPuddG6+ikNPmptxbQ+rKXRy9Fvz22aj8fUYxiQPqb5eU732ObaGs1/yOs/qXYzMnJkEDOWi4kpMWePFj+HTehuQ== X-MS-TrafficTypeDiagnostic: DM5PR02MB2250: X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2250;31:AyA3982GP0XMAIVqr3hK626aXm/L1agCxfaitxY/o2PDbZujmnymJv2nIHmTGei25sKJAkxdFpC+4CJqnlvdOZqQ2EijlcIwSgBMSRkpoN4OHrck5YP3+3c2LNGxr263HUoWXjL81W1DOXSJm9+GwvrBtDmwMvx1kmSgvY1QS9hzpHqXNMx5zJi77fDrk3szBHZNFwDaT0dd8ELE2pVMUTjS+ZORc0D2/ByoXuRRK+Y=;20:1VVvCszxgXp9iN3tuGGcmUBszJ/JqxhT5s1loeMGTmnyiv1aRqehUqpG/pFBNlYHfSPPMNXHeyiudbPqVoEZepKvApZTmvXi1OjlJfG6PSrSEGkAqI9+cNDxczsd9rVt+tA7kT/h1HgMdkDew0rJQ2RRDo60Ay5IS1kBQV8Gcr0JLfUxjlquOEphb2b2cqb+RohiltdmlOqHxfwZLrRK7mJZKh+kpXZIXTjqY7ZFZa1zpN1yDBi7XmbEV6jDtUJrV3CvreJH14+Ap4npeQWwCknyIY0y1y1pJ7yTItkljjj2rPhbATzCowkaYtRn+dgXfIwW/XVsZCbPogGpFOFt5p9PxR4VCWvvnuHRPhH1LFYthZERWC2knZV17EeHZkhZuFB2kDfhGxGLUA3HB4/J5ZK8ehxpU/k5kxozC+dkPwoH5BiJj4dw+nWtmzaRJRtsebbAZJg5/Lkoi+0h8yDTUK+7HZxMnSwzAqRF6jxFVv1ZToxANRG1YVwTSkaqOihq X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(13016025)(5005006)(13018025)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93004095)(6055026)(6041248)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR02MB2250;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR02MB2250; X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2250;4:kwozX6lbmzjXL/XI+wOMgpKogFri0khuQo3W+qiym8/vkn5e5MrNKgipXGlLK3XkF15oZlq157kjrtZfAj4750bDSa46sWiHA4GwIDuCfi93VQDR6wMMMoZh2VyulZRvUnyT0F/uUiEHcgIoCc6i7ytRIogckUSdO7CFbv+a5msb3qB/sCi8Emh0/2Hp7hBFqDW5k6fye5ElU7P+FI42WTZjmRxU1jzXjmAvKqdMZwwrbbx6wcfPmTJlDvxquR+KAEzaJW7aOhrUJYiQiTEhGR8stf8xGZgLQqfdNap/hwE= X-Forefront-PRVS: 039975700A X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjAyTUIyMjUwOzIzOjBGYTNYTnQ5SVd6UElSbTdtRnF5N2orSW96?= =?utf-8?B?VitMSTRqYWJSYndob1RWTmJDZkJTVUZjaFVoczdQWm41Z0pOTTVlZHI3by9z?= =?utf-8?B?am90akxGOUxGejRybXhUYU1xcS9SK3dmZkpvTjZjQ1VRK3ZEOXViZ2liTjND?= =?utf-8?B?SmZnQW80WHRseFBrdFZDTFFXQ2Vyczd4Z29RTWRsRndubFZLcVNpU2p0dmdN?= =?utf-8?B?ZVhRRFcrZWRRYmpPTWVXN0hrc3dPSE5icitsOGxkMlg0ekVCWmcxMGxMc1Ev?= =?utf-8?B?ekwxREppZ1ZKVWtlcmM2L21CbFJPVFJBSmJ3WU5DTEN1SmUvbjRMSXQvNEZw?= =?utf-8?B?MGk2OVYzRFBob0VBaDlqeWE0UVlzSFRacjdUQ1ZYZEluK21Ca3hJQWloUTVR?= =?utf-8?B?cjMrQ0JQYUEyTmg5R3p6MjZLTDMyMEdPOTJBRVJCQmNNUE5nOVFDeXRKQ1VW?= =?utf-8?B?Z1RhZGFhSDRqMlhXZlpZOU11d09meHNtY2J5TTJNeDRnMEpWdWJiQXVQblA1?= =?utf-8?B?eUI0ZTdGczFSSkpUR29vbFk1MXBhdFRyVFJCQjdPeXJLeWFXSnMwWjlWVVNo?= =?utf-8?B?RktSaDBCRHBMd1FPN1JyVk9ZSzdhbXhxcWlTK0xXWit2bVRIcG5qaDk3azgv?= =?utf-8?B?S3lQSXpZSnlTU0dYcGtKdTM1YUhBV0pDaFhLY1V1NUVSTTRITGl6TlBZK2V4?= =?utf-8?B?V1lGcFlKR0huSTR2d05zZEU5YzJyN1F6VTJFRGQ5UE9mSG1EbE9uSUhVRlA5?= =?utf-8?B?RVJ2aXJKZThwc1JZZ1gybFM1cGY1SnpJc0RiU2ZiMjFzd0NzT2V3ZG1nK2Fh?= =?utf-8?B?L2w2eFlsWUNBV3UzTzJiMVdKdVErVFpibjdYMzhXRVZzSFI2TnhWQlk4bnJ1?= =?utf-8?B?NVBydjVXL3BjWkVDazBTOTBTd21iQWRTMnJKNG5TcUtMTEdhS1NzTG5mUEZs?= =?utf-8?B?Nnk5VFZBbi9RcnpRZGp0N3VNREFLdFpsRGJUY1dWWmdnb1dSQzdLSXVjMlBt?= =?utf-8?B?ZjlGVWZ1cFlrY3J4dHJVbXoxcmFnZnJVWUhiUSs0R1BESEZrM0FJOEkvdFJZ?= =?utf-8?B?K3BYVHltdlZZLzA4ZU1PMFVXYU0xYnl0Y2R3ZHpxSytzQ1hkSXFvbGFpWGdo?= =?utf-8?B?M2hxWjdvbWZVd3JKYjRhS29ML0p3SHY4aGpKVjNPRXdSSTJ1SEozeFdqQWNK?= =?utf-8?B?dElUaFlvaW1JQS9UdWNDbnliOTlnQkJnMHZTNWRSMUhRdkRtc2dpMlk2QzRI?= =?utf-8?B?SnkveWRhWE1jWG5tc3M5eGRFc3VwRldCOEFtN0plTGFJQWdXZ2pxdnZDMTF4?= =?utf-8?B?Q1I1TGVCeFIvTEZIRHd1M1RyMU1rSlVVcUZjMHJqb0FBajVtRExaTmZKRllP?= =?utf-8?B?bitKQ3E3Q3VEekttY3BUSEc2aDdxNzhlOVBqRTE1R09oTnZTSzRDVEdKbjZS?= =?utf-8?B?bzhqQ0QvcjdvcENWZ2FteXJMMnliZnA0VGdKVVZCTkp4VnI5bjFjK05HcnVq?= =?utf-8?B?eVVQY0h1QXdneVBTWHpGVjd3ME11czRZZXA3NjZyR0hwbW1TRmJHcnF3YkVm?= =?utf-8?B?ZWN1cWtJdWdrTnlpZGx1MVA1cGtkSDhyVUZrUldUdnhWaXZMUmFPR2hkYmJo?= =?utf-8?Q?x4zvkT1kN1PTHZiW+H4p?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR02MB2250;6:0GPmDNkMeZBqsbZTdPgZZGsLUb+SuFBWXsB+NKl3lAHVV47dB3adIZ6ZqxZzVHaumBJVveBNwmpJ5c2oi2t84epUbiVYZ+WgOG5ZhsPSJam4fenrw7Q7AGzasfpSdASKKv8XsfKBCuhGiMNXvDFyd5Cm3ZN74af1uCIIMt3zcwQ/jvnhRx62AgijzLwPElecQVT8Od6h36JNCjDDA7jrTWD/uv0dWl3US2IFh9VDXCCxpMLjUZkTBMRFtgg8/MnmfrDrrP5zG/tE6JI6rCEm/eX7D7AVhV2Z6c72VxHGwU2bZtsTnM/fP3PsY8k+wjsZHzx4MAOvZIey5f8gKboGgA==;5:DyN4CVJ3wWTE5R2BAK6ek9jwN0qRqtPm/7ixiAZklDvqYS6XHX2wdb7Dfdu0MSCTBfO0l/YYPNCVaNBRIbNApYW+YMccKcQnDhkFIFUkyOq4Q8I35KjSb2FszhzCUQHi/A0Ih87DnaJOYoaxNYKifg==;24:B1Cga6OLZF+fWEqd7OGMDx6mNP5uH+qw3hFsNhO5jBdRV0br6Eg+c8HxWJdDIw5WMIJNwiQC+5IRu25r+LQZNrfP67+K5uelfUBvhyBibU8=;7:fJiXdkQQrRVvXt2shz1411c9DC7+LIIJ6hpFFtOKlqe5Re9Rv+lwkiOG7WdcG58r0Z3ZgQDLmH2BM8xja+XGeiczs8sX1es3aqlf+eQoH/Nj1laWMmZreUrBvVBYNXrFXIOZ9jg8B0sF/bikSde4CLLUjkFrsRgnYWpc3qhtcKMTnewDIvO9Ovu8c4kUKT07IKp5JlMhkic9oNiib1lEgNVdfV9kO1Em7XCkNjCw7S0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2017 14:51:42.6081 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB2250 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 537 Lines: 20 On 14.8.2017 16:47, Guenter Roeck wrote: > On Fri, Aug 04, 2017 at 09:39:16AM +0200, Michal Simek wrote: >> Give read access to module parameters to all and write access to root. >> This change also improves driver error path testing. >> >> Signed-off-by: Michal Simek > > Reviewed-by: Guenter Roeck > >> --- >> >> Please let me know what you think - I can use macros from stat.h if >> required >> > You mean instead of 0644 ? That is discouraged nowadays. yep and good. Thanks, Michal