Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753326AbdHNPa3 (ORCPT ); Mon, 14 Aug 2017 11:30:29 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:37691 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752974AbdHNPaZ (ORCPT ); Mon, 14 Aug 2017 11:30:25 -0400 Subject: Re: [PATCH v3 0/4] add support of SCPSYS power domain for MediaTek MT7622 To: Ulf Hansson , sean.wang@mediatek.com Cc: Rob Herring , "Rafael J. Wysocki" , Kevin Hilman , "devicetree@vger.kernel.org" , linux-mediatek@lists.infradead.org, "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: From: Matthias Brugger Message-ID: <2a112b79-20a0-e09d-28a9-24b412d20874@gmail.com> Date: Mon, 14 Aug 2017 17:30:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 48 On 08/08/2017 01:41 PM, Ulf Hansson wrote: > On 7 August 2017 at 09:24, wrote: >> From: Sean Wang >> >> Changes since v2: >> - reduce code duplication of scpsys_probe across all SoCs >> >> Changes since v1: >> - rebase to Linux v4.13-rc1 >> >> There are four power domains on MediaTek MT7622 SoC which are respectively >> ETHSYS for Ethernet including extra embedded switch, HIF0SYS for PCI-E and >> SATA, HIF1SYS for USB and WBSYS for WIFI and Bluetooth. >> >> Those functions could be selectively powered gated when the corresponding >> function is no longer to use in order to reach more minimal power >> dissipation through the patch series introduced here. >> >> Chen Zhong (1): >> soc: mediatek: add header files required for MT7622 SCPSYS dt-binding >> >> Sean Wang (3): >> dt-bindings: soc: update the binding document for SCPSYS on MediaTek >> MT7622 SoC >> soc: mediatek: reduce code duplication of scpsys_probe across all SoCs >> soc: mediatek: add SCPSYS power domain driver for MediaTek MT7622 SoC >> >> .../devicetree/bindings/soc/mediatek/scpsys.txt | 3 + >> drivers/soc/mediatek/mtk-scpsys.c | 247 ++++++++++++--------- >> include/dt-bindings/power/mt7622-power.h | 22 ++ >> include/linux/soc/mediatek/infracfg.h | 7 + >> 4 files changed, 179 insertions(+), 100 deletions(-) >> create mode 100644 include/dt-bindings/power/mt7622-power.h >> >> -- >> 2.7.4 >> > > Looks good to me! Feel free to add: > > Reviewed-by: Ulf Hansson > Pushed to v4.13-next/soc with the Reviewed-by. Thanks!