Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753852AbdHNPvb (ORCPT ); Mon, 14 Aug 2017 11:51:31 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:37762 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753690AbdHNPv3 (ORCPT ); Mon, 14 Aug 2017 11:51:29 -0400 Subject: Re: [PATCH v2] platform/x86: ideapad-laptop: Expose conservation mode switch To: Andy Shevchenko Cc: Platform Driver , "linux-kernel@vger.kernel.org" , Andy Shevchenko , Darren Hart , Ike Panhc References: From: Hao Wei Tee Message-ID: Date: Mon, 14 Aug 2017 23:51:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Thunderbird/55.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 28 On 14/8/2017 23:32, Andy Shevchenko wrote: > On Mon, Aug 14, 2017 at 5:17 PM, Hao Wei Tee wrote: >> This exposes the battery conservation mode present on some (?) IdeaPads. >> The mode is set by calling ACPI method SBMC with argument 3 (on) or >> 5 (off). Status is reported in bit 5 of the return value of ACPI method >> GBMD. > > Thanks for an update, this looks pretty much good! > > Still some kind of nitpicks below. > >> +#define GBMD_CONSERVATION_BIT (5) > >> +enum { >> + SBMC_CONSERVATION_ON = 3, >> + SBMC_CONSERVATION_OFF = 5, > > Looks to me like > GBMD = Get BM Data > SBMC = Send BM Command > > Thus, I would leave BM only in the above (do you know by the way what > BM stands for? Now that you mention it, it might stand for battery management. -- Hao Wei