Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753720AbdHNP5v (ORCPT ); Mon, 14 Aug 2017 11:57:51 -0400 Received: from g4t3427.houston.hpe.com ([15.241.140.73]:45436 "EHLO g4t3427.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753074AbdHNP5s (ORCPT ); Mon, 14 Aug 2017 11:57:48 -0400 From: "Kani, Toshimitsu" To: "bp@alien8.de" CC: "rjw@rjwysocki.net" , "lenb@kernel.org" , "mchehab@kernel.org" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Topic: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Index: AQHTDKTuWyxK/OMe00e0Ovda8CeGBqJzlIKAgAEZcQCAAIyugIAD9yeAgAW2iQCABSfDgA== Date: Mon, 14 Aug 2017 15:57:35 +0000 Message-ID: <1502725671.2042.137.camel@hpe.com> References: <20170803215753.30553-1-toshi.kani@hpe.com> <20170803215753.30553-5-toshi.kani@hpe.com> <20170804040525.GE12082@nazgul.tnic> <1501879964.2042.117.camel@hpe.com> <20170805051615.GC23214@nazgul.tnic> <1502128177.2042.131.camel@hpe.com> <20170811090414.GB9432@nazgul.tnic> In-Reply-To: <20170811090414.GB9432@nazgul.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.211.195.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DF4PR84MB0185;6:uYnppsomaP5618mjwlr7904NlWC2dq7fS4SDLIWXqsmt8DGayMrPs/psucWvi5/VtrNZKdJrYeomVSVCqJ0ZsWSQY1dQNIcgj9SVkxsqRO+cS+Xjtb/Kb3j7xqaGJzrlARN0h2dGv4ImBRYlXMTwoBuT2YKEv/7Rq3qYQhWXnoW56OTapwe4PivPn6aS81ZpbZGhMH2zSMixGogfIRsK05AHF2h96+YH1P8w91BDenM34IHK/7CAGnBv76ebXJRvKA0rFjovnAe6WZIhB0V3Gr90M9zkU5LtLGZNqBvvDO7MA6R48GBzHjO31N7Z6tqd0KDevoryTpysdZhUQ1cChw==;5:VTJ0alGgRTlAaHdJs43WPfyT2fpVTUtvDzYTO47nx6SvLydaPLX+V+M/HBgr5WGT9zANcrsYjvjWcXLU8lkL7P/Ge/UiINSfA9Itu7ER8kXfqWg0JfY5OjEWJJqczuZa/57QfRhLtNdu5jugsdnHUw==;24:AmgmvUV3JIxaC0q+w+ZzZYuwLc5AlJ3xFSHWE3WXGHl1piVEMVj0FefrnWyP9dq8/qj2UCGjRgfkRL2sJyDK3i/c8qvW/8ybpvAtV+/9d4E=;7:fPWgI7ElRY+To+Lo9UvbYYtG4nxECreQfDmrUiYKh7GhhvoGs97FuNgHl4BfrUZ0Cr+5Yi86j7Y4cPrn5xD4O+5t8TUCm8P61bl7BZIkbJeDjCJH4/tnSBdJ7f3XdE4b3uU6cf05OZ6lVvy99JZF32rKi+38gyT3MfFE48grp9wnZcUHhGOGbDmYqGnbO5Lcxz1qTxOe1S6Igca1Z+Rbj+dc2wTrbnXj0PHpK6IkSCI= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 96f50f42-a1da-42a9-18a4-08d4e32d2e97 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DF4PR84MB0185; x-ms-traffictypediagnostic: DF4PR84MB0185: x-exchange-antispam-report-test: UriScan:(211171220733660); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0185;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0185; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(377424004)(189002)(24454002)(199003)(68736007)(478600001)(8936002)(2906002)(6506006)(3660700001)(86362001)(14454004)(105586002)(25786009)(81166006)(229853002)(5660300001)(305945005)(8676002)(7736002)(1730700003)(6916009)(2950100002)(3846002)(3280700002)(102836003)(6116002)(2501003)(6436002)(6486002)(81156014)(77096006)(66066001)(103116003)(6512007)(189998001)(50986999)(101416001)(76176999)(54356999)(36756003)(106356001)(33646002)(54906002)(93886004)(97736004)(5640700003)(2900100001)(110136004)(4326008)(2351001)(53936002)(6246003);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0185;H:DF4PR84MB0187.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 15:57:35.8895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0185 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7EFvtuk016182 Content-Length: 641 Lines: 19 On Fri, 2017-08-11 at 11:04 +0200, Borislav Petkov wrote: > On Mon, Aug 07, 2017 at 05:59:15PM +0000, Kani, Toshimitsu wrote: > > I think we should keep the current scheme, which registers an mci > > for > > No we shouldn't. > > > each GHES entry.  ghes_edac_report_mem_error() expects that error- > > reporting is serialized per a GHES entry.  Sharing a single mci > > among all GHES entries / error interfaces might lead to a race > > condition. > > See how I solved it in my patchset and feel free to reuse it. Hmm... Sorry, I failed to see how your patchset solved it. Would you mind to explain how it is done? Thanks! -Toshi