Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752401AbdHNQic (ORCPT ); Mon, 14 Aug 2017 12:38:32 -0400 Received: from verein.lst.de ([213.95.11.211]:58113 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbdHNQib (ORCPT ); Mon, 14 Aug 2017 12:38:31 -0400 Date: Mon, 14 Aug 2017 18:38:29 +0200 From: Christoph Hellwig To: Dave Jones , Linux Kernel Mailing List , James Smart , Christoph Hellwig Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return Message-ID: <20170814163829.GA27442@lst.de> References: <20170811194419.4F5D82205C@pdx-korg-gitolite-1.ci.codeaurora.org> <20170814141924.sabddysk2bdg6vek@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170814141924.sabddysk2bdg6vek@codemonkey.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 350 Lines: 11 On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote: > > + > > + /* Cleanup defer'ed IOs in queue */ > > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) { > > + list_del(&deferfcp->req_list); > > + kfree(deferfcp); > > + } > > Shouldn't this be list_for_each_entry_safe ? It should. James, can you send a fixup?