Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753018AbdHNQtD (ORCPT ); Mon, 14 Aug 2017 12:49:03 -0400 Received: from g2t2352.austin.hpe.com ([15.233.44.25]:38598 "EHLO g2t2352.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752426AbdHNQtA (ORCPT ); Mon, 14 Aug 2017 12:49:00 -0400 From: "Kani, Toshimitsu" To: "bp@alien8.de" CC: "linux-edac@vger.kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" , "rjw@rjwysocki.net" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Topic: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Index: AQHTDKTuWyxK/OMe00e0Ovda8CeGBqJzlIKAgAEZcQCAAIyugIAD9yeAgAW2iQCABSfDgIAACkUAgAAEFwA= Date: Mon, 14 Aug 2017 16:48:57 +0000 Message-ID: <1502728754.2042.139.camel@hpe.com> References: <20170803215753.30553-1-toshi.kani@hpe.com> <20170803215753.30553-5-toshi.kani@hpe.com> <20170804040525.GE12082@nazgul.tnic> <1501879964.2042.117.camel@hpe.com> <20170805051615.GC23214@nazgul.tnic> <1502128177.2042.131.camel@hpe.com> <20170811090414.GB9432@nazgul.tnic> <1502725671.2042.137.camel@hpe.com> <20170814162436.lta5xm742hh6g7yk@pd.tnic> In-Reply-To: <20170814162436.lta5xm742hh6g7yk@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.211.195.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DF4PR84MB0188;6:nSDZOuzCH9Cb7grdY+DHuXoXf/onSAvCr30cn3SVNBe0whLN6ech9xCZeBPnNtEcpW88VIB9O0pjNO9ftsG1Fbc4lYEnc7Mh8USMhgRruzX1OHJsjA2zax1O6Q5HvwE8lvBbBt7Kc9YKHMPQyEsrB6diN/TzVMvN2RcIpayzVhFH5v6R2sfII77OjdPZeVMXtPKYGEdBcg/THpztaUr9FZVb2AXissYMb9EN/QFrJxIndquLN68CHyfOLN5DmSnPHEn46pEXb6JFi4uvx4nEQd0qgEFlleEmyOUHe80nONY8H0B9BUctnZGqaiqLssTKigJir/PfHLG8DBIAPGWPvg==;5:IPaVMTYoaPdKLgR/Fe3/cAKAs4xzH30WNk3BorrAtVZdrvKOsGHTmAVtHJAqBSO3FR4mMohiCYns8MTHbbvvGg+INn2icrejPrHrKYhHWDr1qO8HM2+1h/xsHvG+ps/+ETStmqIGjkjV8/Upss0Njg==;24:gMilmA1yhZ+l7Cva3q9R1AFOcP7BkOc61qjE1uMDS1zd6PzfDelzK0Sr8EfdHFufj4xHAjW6STOw8W9pWfAdPpDD5ce/LEbvphM7ozJaTPU=;7:pojdECTf/mBv09ZgzKOnRmqOVI8pmA+b9aCabi7SYwWETkyrwa8wFuyxm9ID6icemPt/8MhV4sGazgJ/TSqQF/qMGk6WmC4GKS0VqgibyfnsLWbStMTy9pbX1Qaoztp50d3ARUR3OLh/VpBX1ZHXDnHFJ/pELJBW0P4rBpUnk1ohxVF+d4p6gEMypzJPYbRdfNsfVhmOk7QfqI0rccRxHdIxRI7kRiMki3/3zpPloqU= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 54b179f3-af89-48aa-25a0-08d4e3345ba0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DF4PR84MB0188; x-ms-traffictypediagnostic: DF4PR84MB0188: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0188;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0188; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(377424004)(199003)(24454002)(189002)(3660700001)(106356001)(5660300001)(93886004)(53936002)(86362001)(2906002)(110136004)(3280700002)(5640700003)(6512007)(25786009)(54906002)(6246003)(66066001)(14454004)(68736007)(478600001)(103116003)(33646002)(2351001)(105586002)(36756003)(4326008)(305945005)(6916009)(50986999)(229853002)(189998001)(76176999)(2900100001)(2950100002)(7736002)(2501003)(54356999)(8676002)(81156014)(1730700003)(81166006)(102836003)(3846002)(6506006)(6486002)(6436002)(77096006)(97736004)(6116002)(101416001)(8936002);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0188;H:DF4PR84MB0187.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 16:48:57.9859 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0188 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7EGn7QR020364 Content-Length: 724 Lines: 22 On Mon, 2017-08-14 at 18:24 +0200, Borislav Petkov wrote: > On Mon, Aug 14, 2017 at 03:57:35PM +0000, Kani, Toshimitsu wrote: > > Hmm... Sorry, I failed to see how your patchset solved it.  Would > > you mind to explain how it is done? > > +static int __init ghes_edac_register(void) >  { > +       struct ghes_edac_pvt *pvt = ghes_pvt; > > Only one local ghes_pvt structure. > > And you handle multiple calls into ghes_edac_register() by exiting > all those which are not the first one as the first one already did > all the init. Right, but the issue is how [ghes_edac_]report_mem_error() protects from possible concurrent calls from multiple GHES sources when there is only a single mci. Thanks, -Toshi