DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F2EA22DE42D
Date: Mon, 14 Aug 2017 18:43:10 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Dmitry Safonov <dsafonov@virtuozzo.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
        Cyrill Gorcunov <gorcunov@openvz.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: fix norandmaps
Message-ID: <20170814164310.GA9897@redhat.com>
References: <20170710111429.GA20038@redhat.com>
 <20170814162457.w7ddsrmco73cfbai@node.shutemov.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170814162457.w7ddsrmco73cfbai@node.shutemov.name>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 865
Lines: 25

On 08/14, Kirill A. Shutemov wrote:
>
> On Mon, Jul 10, 2017 at 01:14:29PM +0200, Oleg Nesterov wrote:
> > Documentation/admin-guide/kernel-parameters.txt says:
> > 
> >     norandmaps  Don't use address space randomization. Equivalent
> >                 to echo 0 > /proc/sys/kernel/randomize_va_space
> > 
> > but it doesn't work because arch_rnd() which is used to randomize
> > mm->mmap_base returns a random value unconditionally.
> > 
> > Shift the PF_RANDOMIZE check from arch_mmap_rnd() to arch_rnd().
> > 
> > Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()")
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> 
> It also fixes personality(ADDR_NO_RANDOMIZE).

Yes, good point.

> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

OK, thanks Kirill and Cyrill, I'll resend tomorrow with all acks I got.

Oleg.