Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbdHNREF (ORCPT ); Mon, 14 Aug 2017 13:04:05 -0400 Received: from mail-cys01nam02on0115.outbound.protection.outlook.com ([104.47.37.115]:18707 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751445AbdHNRED (ORCPT ); Mon, 14 Aug 2017 13:04:03 -0400 From: Long Li To: Christoph Hellwig CC: Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1 Thread-Topic: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1 Thread-Index: AQHTC8ugiSGSvCPGr06Z0FxF4NGfkaKCJfeAgAIAddA= Date: Mon, 14 Aug 2017 17:04:00 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <20170813102735.GI17287@infradead.org> In-Reply-To: <20170813102735.GI17287@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-14T10:03:59.5097351-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:c::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0134;6:MmdQ5c7ZVk3zAFvX8ItqqCqCU4Shov0C6KKF1rzDMZRhaCb/8LdMSJZ6l2rWP764aO6i90Zc2es3UudQPcCY5Gh2S6MQjJa4cSvJHW+sajZlK4bDrrI9VLkrlQONvtefqWxwLoSqiR0LzA5972bw50NjilV+AOUOdGlNXLVlJgTrA/4l4xJdTXDCRt4YwAEtqzQH4+9M9WFFttkgtx9G/0WwK4l+7FjUSY7KbWGmRDJ3Dkcgjt1z97vR4jc4+6jSiAr4dw5sNUFqjbE/HOxNMemjLHOh+SnEozcTjA3iQkRuK8u/upSOSLQ/Y0s4YvWup5riD3yHHr3dJ2fgqotb7g==;5:MCQkkx7RLPLTfj3LaCmLWPR+I5ryLG7dJgHk3DpktEazjh3bNUcjKfnZCGTV70B+weClahWb/26eaDu5vX+67/gxN+96QWEvkQd1UDeiOumCisCBnHkAAMJDHf94IevUusESfLQ5CYSKWZJa1HfeRg==;24:mmR7sidjxSFTF+kBZYP/KCkxD1+tTRDUZpxhbV2nBQuM9SsLYppkxBQCcWDbsQuNHn1B1VJaVlP9XwI6GHh92VD7HOGjDUe2+6XB1Pp2COI=;7:SpAFsnoY2tPYBZ89/EquF+pLO2FvWwD0X83w7i6Jxo9TKVCdEUfnkO2r7t0ZzL5q7mpnAEHiFF2c63cO2ZaD5/z/8IOaW9iLkum1zSyQRUpXzei+gWrMoPaAhUC6p4ThjU21SnvfIkqt8Lerd2YMz4AoZun7IFv2UmeWbEJY62sbR4hF/7kup5EkfRt5PwF8Fl329wM/GAnUtp2SRg8NPmYvw/4WThW8EKGuzAkqbPU= x-ms-office365-filtering-correlation-id: ad5047ed-8028-4fe0-206b-08d4e33675f3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603140)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0134; x-ms-traffictypediagnostic: CY4PR21MB0134: x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0134;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0134; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(377454003)(13464003)(189002)(199003)(86362001)(10090500001)(229853002)(76176999)(50986999)(3280700002)(2906002)(105586002)(3660700001)(77096006)(99286003)(6506006)(106356001)(6436002)(54356999)(81156014)(81166006)(86612001)(55016002)(6116002)(8936002)(8676002)(102836003)(9686003)(33656002)(6916009)(25786009)(2950100002)(101416001)(54906002)(4326008)(14454004)(8990500004)(345774005)(5005710100001)(7736002)(53936002)(478600001)(97736004)(68736007)(7696004)(305945005)(6246003)(110136004)(2900100001)(74316002)(53546010)(5660300001)(10290500003)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0134;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 17:04:01.0970 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EH49k3020477 Content-Length: 1144 Lines: 35 > -----Original Message----- > From: Christoph Hellwig [mailto:hch@infradead.org] > Sent: Sunday, August 13, 2017 3:28 AM > To: Long Li > Cc: Steve French ; linux-cifs@vger.kernel.org; samba- > technical@lists.samba.org; linux-kernel@vger.kernel.org; Long Li > > Subject: Re: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1 > > Hi Long, > > a few meta-comments: > > first the split into lots of tiny lists makes the series really hard to read, I'd split > it into just a few: > > Patch 1: add the protocol constants > Patch 2-n: core cifs modifcation required to implement SMBD Patch n+1: > add the actual SMBD code Patch n+2..m: write up the core CIFS code to use > it. > > stcond a lot of the code doesn't seem to follow the usual Linux style. > It might be a good idea to run it through scripts/checkpach.pl and at least fix > the errors it generates. The warnings are much more opinioned so feel free > to ignore them if they sound odd for now. Hi Christoph Thank you for reviewing the patch set. I'll address those comments and update the patches. Long