Date: Mon, 14 Aug 2017 10:30:02 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pan Bian <bianpan2016@163.com>
Cc: Lee Jones <lee.jones@linaro.org>,
        Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
        Marek Vasut <marex@denx.de>, Dan Carpenter <dan.carpenter@oracle.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: input: touchscreen: mxs-lradc: use correct error check
Message-ID: <20170814173002.GB15368@dtor-ws>
References: <1502197237-19251-1-git-send-email-bianpan2016@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1502197237-19251-1-git-send-email-bianpan2016@163.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1110
Lines: 35

On Tue, Aug 08, 2017 at 09:00:37PM +0800, Pan Bian wrote:
> Function devm_ioremap() will return a NULL pointer on failure. However,
> in function mxs_lradc_ts_probe(), its return value is checked with
> IS_ERR(), which cannot detect the exceptional case.
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/mxs-lradc-ts.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
> index 58c016c..9bcc98c6 100644
> --- a/drivers/input/touchscreen/mxs-lradc-ts.c
> +++ b/drivers/input/touchscreen/mxs-lradc-ts.c
> @@ -631,8 +631,8 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev)
>  
>  	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	ts->base = devm_ioremap(dev, iores->start, resource_size(iores));
> -	if (IS_ERR(ts->base))
> -		return PTR_ERR(ts->base);
> +	if (!ts->base)
> +		return -ENOMEM;
>  
>  	ret = of_property_read_u32(node, "fsl,lradc-touchscreen-wires",
>  				   &ts_wires);
> -- 
> 1.9.1
> 
> 

-- 
Dmitry