DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A671123964
Date: Mon, 14 Aug 2017 13:33:41 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Federico Vaga <federico.vaga@vaga.pv.it>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 2/2] It makes the code clearer and less error prone.
Message-ID: <20170814133341.05028184@gandalf.local.home>
In-Reply-To: <20170802221558.9684-2-federico.vaga@vaga.pv.it>
References: <20170802221558.9684-1-federico.vaga@vaga.pv.it>
        <20170802221558.9684-2-federico.vaga@vaga.pv.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1024
Lines: 32

On Thu,  3 Aug 2017 00:15:58 +0200
Federico Vaga <federico.vaga@vaga.pv.it> wrote:

Why did you change the subject? The previous patch had a much better
one: "trace-cmd: Use asprintf when possible"

Or was it the tool you used to send the patches that chopped it off?

A quick scan of the patch looks good. I'll look a bit deeper at it, and
if I don't find anything, I'll apply it (and fix the subject).

Thanks!

-- Steve

> clearer:
> - less code
> - the code is now using the same format to create strings dynamically
> 
> less error prone:
> - no magic number +2 +9 +5 to compute the size
> - no copy&paste of the strings to compute the size and to concatenate
> 
> The function `asprintf` is not POSIX standard but the program
> was already using it. Later it can be decided to use only POSIX
> functions, then we can easly replace all the `asprintf(3)` with a local
> implementation of that function.
> 
> Signed-off-by: Federico Vaga <federico.vaga@vaga.pv.it>
> ---
>  event-plugin.c   | 24 ++++++++--------------
>