Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdHNR5i (ORCPT ); Mon, 14 Aug 2017 13:57:38 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33143 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365AbdHNR5h (ORCPT ); Mon, 14 Aug 2017 13:57:37 -0400 Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return To: Christoph Hellwig , Dave Jones , Linux Kernel Mailing List References: <20170811194419.4F5D82205C@pdx-korg-gitolite-1.ci.codeaurora.org> <20170814141924.sabddysk2bdg6vek@codemonkey.org.uk> <20170814163829.GA27442@lst.de> From: James Smart Message-ID: <9ec45c45-0a9d-1bb5-8a10-ed9ab5e072db@gmail.com> Date: Mon, 14 Aug 2017 10:57:32 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170814163829.GA27442@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 513 Lines: 18 On 8/14/2017 9:38 AM, Christoph Hellwig wrote: > On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote: >> > + >> > + /* Cleanup defer'ed IOs in queue */ >> > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) { >> > + list_del(&deferfcp->req_list); >> > + kfree(deferfcp); >> > + } >> >> Shouldn't this be list_for_each_entry_safe ? > > It should. James, can you send a fixup? > yes - I was had already identified this fix and in the process of putting it out. -- james