Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138AbdHNSyk (ORCPT ); Mon, 14 Aug 2017 14:54:40 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:35927 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbdHNSyj (ORCPT ); Mon, 14 Aug 2017 14:54:39 -0400 Date: Mon, 14 Aug 2017 20:54:25 +0200 From: Peter Zijlstra To: Minchan Kim Cc: Ingo Molnar , Stephen Rothwell , Andrew Morton , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux-Next Mailing List , Linux Kernel Mailing List , Nadav Amit , Linus Subject: Re: linux-next: manual merge of the akpm-current tree with the tip tree Message-ID: <20170814185425.GM6524@worktop.programming.kicks-ass.net> References: <20170811175326.36d546dc@canb.auug.org.au> <20170811093449.w5wttpulmwfykjzm@hirez.programming.kicks-ass.net> <20170811214556.322b3c4e@canb.auug.org.au> <20170811115607.p2vgqcp7w3wurhvw@gmail.com> <20170811140450.irhxa2bhdpmmhhpv@hirez.programming.kicks-ass.net> <20170814030914.GC25427@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170814030914.GC25427@bbox> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 421 Lines: 12 On Mon, Aug 14, 2017 at 12:09:14PM +0900, Minchan Kim wrote: > @@ -446,9 +450,7 @@ void tlb_finish_mmu(struct mmu_gather *tlb, > * > */ > bool force = mm_tlb_flush_nested(tlb->mm); > - > arch_tlb_finish_mmu(tlb, start, end, force); > - dec_tlb_flush_pending(tlb->mm); > } No, I think this breaks all the mm_tlb_flush_pending() users. They need the decrement to not be visible until the TLB flush is complete.