Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752273AbdHNT2u (ORCPT ); Mon, 14 Aug 2017 15:28:50 -0400 Received: from mail-by2nam01on0092.outbound.protection.outlook.com ([104.47.34.92]:43301 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751540AbdHNT2r (ORCPT ); Mon, 14 Aug 2017 15:28:47 -0400 From: Tom Talpey To: Christoph Hellwig , Long Li CC: Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 04/37] [CIFS] SMBD: Define per-channel SMBD transport parameters and default values Thread-Topic: [[PATCH v1] 04/37] [CIFS] SMBD: Define per-channel SMBD transport parameters and default values Thread-Index: AQHTC808c9LjcwmZD0+TaHRf/ESp/aKCIZQAgAIrWoA= Date: Mon, 14 Aug 2017 19:28:45 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-5-git-send-email-longli@exchange.microsoft.com> <20170813101156.GB17287@infradead.org> In-Reply-To: <20170813101156.GB17287@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [24.218.182.144] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0504;6:qW2jmYfz2jd0ggdvv12NWoVv6AROzKITiiQ7oxqKk0OkZWG5A5ksXS1QtaO3y9nFZrErvxrYmv851QjEWEjW7WDfN5tC1t5hHBrZIfXTooLOyzP65etiOZqZ59Vc+E4CqkphsK326DSX8Lfx3hxeMxrw0LHxjwUs4IbPlMj1UZGDD9aTtqJAnWIQ1FeBaUHrufCeg3tu/hYlc5mOnvedBYtLmJNF/8hJRCrsv4l4tEWFAX9JVKR+a3KaOq8r5Z6hEcAhw/X+BXzOccgNg7+alH/JkXLLIZE00dB7fYgjVSWaV/xO+u+f97jeL27Tut/QU1P0A/sb0R+DNdtyPDDoaA==;5:1l1iNkz3HU/RZF4IF35P+kJwleelBK2X3a73oOJTB46jrK1wVGIaoQbUN6RQe/Zf33e/SMkBXMCgyJnTGpWfIsXPf/fwpgF5QDTWmB0SllVzQTSQFpfxqeNfjfS/J3x8WFV3NXjKGI6MGz8Vjoedtg==;24:S9u18U4Rv2TUP81WmgVSJQw/ECPyasqB2xb4Gug0Du7YGIzHecr06g+M0FXZUViuv4huZw1zY8AAR03RumOT02XODTOEeIR3bASaqI2nw1c=;7:9LT9+66Vz6Psp6xrR5G6iQi7iGvJph0CEjsez3OWs4XTddPGTfUtpqaZchaIHhfSUaMMCRnyXKpiGJLA4QJMrm0YWMjXAlUn9WoEuvWybR+5oorNWeBQasVkBJtwdWRBOT5cFC/XnMtJ7C4tABK9QNggJMy50tPaY2kRdlqk7wwPENYzvV8AZQDzCB8nYAJ0Qk9/s+BvSoqNjs0WiX00WUA2tTgsRK+pRunZOTBIPC4= x-ms-office365-filtering-correlation-id: 3c399272-bc1f-48fa-88df-08d4e34aae67 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603142)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0504; x-ms-traffictypediagnostic: CY4PR21MB0504: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ttalpey@microsoft.com; x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041248)(20161123558100)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0504;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0504; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(189002)(13464003)(377454003)(199003)(8936002)(54906002)(10090500001)(97736004)(189998001)(81166006)(81156014)(8676002)(1511001)(102836003)(6116002)(3846002)(5005710100001)(305945005)(86612001)(7736002)(99286003)(2906002)(86362001)(10290500003)(6636002)(25786009)(2950100002)(9686003)(53936002)(6246003)(55016002)(68736007)(66066001)(478600001)(54356999)(76176999)(229853002)(77096006)(8990500004)(6506006)(3280700002)(6436002)(50986999)(2561002)(101416001)(2900100001)(14454004)(33656002)(106356001)(74316002)(7696004)(5660300001)(3660700001)(53546010)(2421001)(4326008)(105586002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0504;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 19:28:45.7313 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0504 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EJSsth028116 Content-Length: 1274 Lines: 33 > -----Original Message----- > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > owner@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Sunday, August 13, 2017 6:12 AM > To: Long Li > Cc: Steve French ; linux-cifs@vger.kernel.org; samba- > technical@lists.samba.org; linux-kernel@vger.kernel.org; Long Li > > Subject: Re: [[PATCH v1] 04/37] [CIFS] SMBD: Define per-channel SMBD > transport parameters and default values > > > +/* > > + * Per RDMA transport connection parameters > > + * as defined in [MS-SMBD] 3.1.1.1 > > + */ > > +static int receive_credit_max = 512; > > +static int send_credit_target = 512; > > +static int max_send_size = 8192; > > +static int max_fragmented_recv_size = 1024*1024; > > +static int max_receive_size = 8192; > > Are these protocol constants? If so please use either #defines > or enums with upper case names for them. These are not defined constants, but the values beg for some explanatory text why they are chosen. Windows uses, and negotiates by default, a 1364-byte maximum send size, and caps credits to 255. The other values match. BTW, the parameters are defined in MS-SMBD 3.1.1.1 but the chosen values are in behavior notes 2 and 7. Tom.