Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbdHNU07 (ORCPT ); Mon, 14 Aug 2017 16:26:59 -0400 Received: from mail-co1nam03on0090.outbound.protection.outlook.com ([104.47.40.90]:57376 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751635AbdHNU05 (ORCPT ); Mon, 14 Aug 2017 16:26:57 -0400 From: Tom Talpey To: Long Li , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 15/37] [CIFS] SMBD: Post a SMBD data transfer message with data payload Thread-Topic: [[PATCH v1] 15/37] [CIFS] SMBD: Post a SMBD data transfer message with data payload Thread-Index: AQHTC8z8ld7ITXs0b0aZ3+FtVXGXXKKEXyFA Date: Mon, 14 Aug 2017 20:26:55 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-16-git-send-email-longli@exchange.microsoft.com> In-Reply-To: <1501704648-20159-16-git-send-email-longli@exchange.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [24.218.182.144] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0694;6:UGCS95EDOJmwLShl5ph4xn/OvGgLN5mYGQJ2XGkyAkg6+Imo4+7DM0Jb0PzWdv4bpR1BNc6NxJ6OmVxfzybqPNP+f1rKN13AScIc0CWd8BtOkFH78hBiTU9ZJBzEUyDhKX7Un3VCmfywJbEtpjVCG2+PkEaNh9XrgIzjiCA1gPcTzlH+prRaUH+BLFwt1qKtXqlemKw4qkOLkRhosvloXVbG8DIVc+SHAj0Aipo2jW1l8hV22QOqJDUG/ka68AsaRj129DSGNAMkQlQ7xNWnTv1mK+K4Q/LRa3WdlibGhUFQK/GicnKIkwbw8hF7dFLFmU2UaWyzhXBiSeN5UBAOzA==;5:f4fiU+LzL6JpdiTAPPjqvPpXtAsEw18/uBdglZZgGQA9WJddUMGWKjNwsvowZrCoDtrsmtky//qdXkF1I52U5Yv/9w7w7f1mU3QNSFHSNmKt2p6ChAvfVWWtCcDyHmyq2GEPT4WtGZEhI3fLz5RPkA==;24:SC/puTSelDdNajL/67UICRSRIbnzqiDH+nxbMF90vchCRBwrYtg1lH4bKybiN+QMr98g2QE4I9dLJyF0EwmBTf+LboHGSXLAgOO9itu+ms0=;7:NBg73NoxK4s5/47Tgp+eupLgQycN4VAFGy0/d2A3/dAs2yRVzG2Rk9lYTFPzgDglaJQJfQIuDdobgBJM0ivhkbIDDArdCq+YzCk+i5qbx19y9df8UxGV4AmBpBsnodNK25xLOR0YvagSjrzYdb1ZbK8suf/IBSfKF1OH68qAFyoVowmUVgvt94tHgFvGLGF5PuPZ9aYRTNZ6lf7SawxA65WhivpR4IfZjxxx8SrvHlE= x-ms-office365-filtering-correlation-id: fdfbc0ff-cbef-4644-c4ca-08d4e352ceaf x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603142)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0694; x-ms-traffictypediagnostic: CY4PR21MB0694: x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0694;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0694; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(377454003)(189002)(13464003)(199003)(86612001)(66066001)(86362001)(68736007)(74316002)(14454004)(53546010)(2950100002)(2501003)(189998001)(3660700001)(217423001)(6116002)(3846002)(15650500001)(102836003)(5660300001)(6436002)(229853002)(2201001)(1511001)(7696004)(77096006)(6506006)(9686003)(99286003)(3280700002)(55016002)(76176999)(54356999)(50986999)(6246003)(25786009)(10090500001)(101416001)(53936002)(10290500003)(106356001)(7736002)(105586002)(478600001)(305945005)(2906002)(33656002)(8990500004)(8676002)(5005710100001)(2900100001)(81166006)(97736004)(8936002)(81156014)(226483002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0694;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=ttalpey@microsoft.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 20:26:55.8656 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0694 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EKR4Hl031708 Content-Length: 1260 Lines: 30 > -----Original Message----- > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > owner@vger.kernel.org] On Behalf Of Long Li > Sent: Wednesday, August 2, 2017 4:10 PM > To: Steve French ; linux-cifs@vger.kernel.org; samba- > technical@lists.samba.org; linux-kernel@vger.kernel.org > Cc: Long Li > Subject: [[PATCH v1] 15/37] [CIFS] SMBD: Post a SMBD data transfer message > with data payload > > Similar to sending transfer message with page payload, this function creates a > SMBD data packet and send it over to RDMA, from iov passed from upper layer. The following routine is heavily redundant with 14/37 cifs_rdma_post_send_page(). Because they share quite a bit of protocol and DMA mapping logic, strongly suggest they be merged. Tom. > +static int cifs_rdma_post_send_data( > + struct cifs_rdma_info *info, > + struct kvec *iov, int n_vec, int remaining_data_length); > static int cifs_rdma_post_send_page(struct cifs_rdma_info *info, > struct page *page, unsigned long offset, > size_t size, int remaining_data_length); > @@ -671,6 +674,122 @@ static int cifs_rdma_post_send_page(struct > cifs_rdma_info *info, struct page *pa > }