Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbdHNUeQ (ORCPT ); Mon, 14 Aug 2017 16:34:16 -0400 Received: from mail-wr0-f169.google.com ([209.85.128.169]:33529 "EHLO mail-wr0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbdHNUeP (ORCPT ); Mon, 14 Aug 2017 16:34:15 -0400 MIME-Version: 1.0 In-Reply-To: <0a208d60-7210-1ec0-9c71-71e100175f8b@osg.samsung.com> References: <20170809220508.25437-1-shuahkh@osg.samsung.com> <0a208d60-7210-1ec0-9c71-71e100175f8b@osg.samsung.com> From: John Stultz Date: Mon, 14 Aug 2017 13:34:13 -0700 Message-ID: Subject: Re: [PATCH] selftests: timers: freq-step: fix compile error To: Shuah Khan Cc: Shuah Khan , Thomas Gleixner , Stephen Boyd , lkml , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EKYL25031759 Content-Length: 1218 Lines: 37 On Mon, Aug 14, 2017 at 1:17 PM, Shuah Khan wrote: > On 08/14/2017 02:12 PM, John Stultz wrote: >> On Wed, Aug 9, 2017 at 3:05 PM, Shuah Khan wrote: >>> Fix compile error due to ksft_exit_skip() update to take var_args. >>> >>> freq-step.c: In function ‘init_test’: >>> freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’ >>> ksft_exit_skip(); >>> ^~~~~~~~~~~~~~ >>> In file included from freq-step.c:26:0: >>> ../kselftest.h:167:19: note: declared here >>> static inline int ksft_exit_skip(const char *msg, ...) >>> ^~~~~~~~~~~~~~ >>> : recipe for target 'freq-step' failed >>> >>> Signed-off-by: Shuah Khan >> >> >> Acked-by: John Stultz >> >> This is a build regression in 4.13-rc so should go-to Linus promptly. >> >> (Shuah: Let me know if you want me to send this in via Thomas, or you >> want to send it in directly) >> >> thanks >> -john >> > > John, > > I am planning to send it to Linus with a few other fixes in linux-kselftest > fixes branch for 4.13-rc6 Great! Thanks again for sending this out and sorry for not replying sooner! -john