Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbdHNUrH (ORCPT ); Mon, 14 Aug 2017 16:47:07 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:38234 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752199AbdHNUrF (ORCPT ); Mon, 14 Aug 2017 16:47:05 -0400 Subject: Re: [PATCH 2/2] leds: lm3533: constify attribute_group structure To: Amitoj Kaur Chawla , rpurdie@rpsys.net, pavel@ucw.cz, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170810162809.GA6903@amitoj-Inspiron-3542> From: Jacek Anaszewski Message-ID: Date: Mon, 14 Aug 2017 22:46:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170810162809.GA6903@amitoj-Inspiron-3542> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1323 Lines: 41 Hi Amitoj, Thanks for the patch, applied. Best regards, Jacek Anaszewski On 08/10/2017 06:28 PM, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec hex filename > 8272 4608 64 12944 3290 drivers/leds/leds-lm3533.o > > File size after: > text data bss dec hex filename > 8368 4512 64 12944 3290 drivers/leds/leds-lm3533.o > > This change was made with the help of Coccinelle. > > Signed-off-by: Amitoj Kaur Chawla > --- > drivers/leds/leds-lm3533.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c > index 5b529dc..72224b5 100644 > --- a/drivers/leds/leds-lm3533.c > +++ b/drivers/leds/leds-lm3533.c > @@ -626,7 +626,7 @@ static umode_t lm3533_led_attr_is_visible(struct kobject *kobj, > return mode; > }; > > -static struct attribute_group lm3533_led_attribute_group = { > +static const struct attribute_group lm3533_led_attribute_group = { > .is_visible = lm3533_led_attr_is_visible, > .attrs = lm3533_led_attributes > }; >