Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752349AbdHNU71 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 14 Aug 2017 16:59:27 -0400
Received: from mail-wm0-f52.google.com ([74.125.82.52]:35826 "EHLO
        mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751644AbdHNU7Z (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 14 Aug 2017 16:59:25 -0400
MIME-Version: 1.0
In-Reply-To: <0a208d60-7210-1ec0-9c71-71e100175f8b@osg.samsung.com>
References: <20170809220508.25437-1-shuahkh@osg.samsung.com>
 <CALAqxLUxCHwDyqefHz=bmPC=6tEQQdfx2MWQRYLxGJ21zeHHUQ@mail.gmail.com> <0a208d60-7210-1ec0-9c71-71e100175f8b@osg.samsung.com>
From: John Stultz <john.stultz@linaro.org>
Date: Mon, 14 Aug 2017 13:59:23 -0700
Message-ID: <CALAqxLXHX_W68ufGJOWv5ECBQFFG=451EMfKQN0L4eL9eUmCCw@mail.gmail.com>
Subject: Re: [PATCH] selftests: timers: freq-step: fix compile error
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Shuah Khan <shuah@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@codeaurora.org>,
        lkml <linux-kernel@vger.kernel.org>, linux-kselftest@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EKxWJU002980
Content-Length: 1267
Lines: 39

On Mon, Aug 14, 2017 at 1:17 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 08/14/2017 02:12 PM, John Stultz wrote:
>> On Wed, Aug 9, 2017 at 3:05 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>> Fix compile error due to ksft_exit_skip() update to take var_args.
>>>
>>> freq-step.c: In function ‘init_test’:
>>> freq-step.c:234:3: error: too few arguments to function ‘ksft_exit_skip’
>>>    ksft_exit_skip();
>>>    ^~~~~~~~~~~~~~
>>> In file included from freq-step.c:26:0:
>>> ../kselftest.h:167:19: note: declared here
>>>  static inline int ksft_exit_skip(const char *msg, ...)
>>>                    ^~~~~~~~~~~~~~
>>> <builtin>: recipe for target 'freq-step' failed
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>
>>
>> Acked-by: John Stultz <john.stultz@linaro.org>
>>
>> This is a build regression in 4.13-rc so should go-to Linus promptly.
>>
>> (Shuah: Let me know if you want me to send this in via Thomas, or you
>> want to send it in directly)
>>
>> thanks
>> -john
>>
>
> John,
>
> I am planning to send it to Linus with a few other fixes in linux-kselftest
> fixes branch for 4.13-rc6

I also have two more less critical build fixups to that test to add,
which I'll send out here in a second for review.

thanks
-john