Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752613AbdHNU77 (ORCPT ); Mon, 14 Aug 2017 16:59:59 -0400 Received: from mail-sn1nam02on0119.outbound.protection.outlook.com ([104.47.36.119]:43180 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752483AbdHNU7z (ORCPT ); Mon, 14 Aug 2017 16:59:55 -0400 From: Tom Talpey To: Long Li , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: RE: [[PATCH v1] 22/37] [CIFS] SMBD: Implement API for upper layer to receive data to page Thread-Topic: [[PATCH v1] 22/37] [CIFS] SMBD: Implement API for upper layer to receive data to page Thread-Index: AQHTC8usjCm1a1620Uayyg9v05JJ7qKEaEvw Date: Mon, 14 Aug 2017 20:59:50 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-23-git-send-email-longli@exchange.microsoft.com> In-Reply-To: <1501704648-20159-23-git-send-email-longli@exchange.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [24.218.182.144] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0184;6:TJ8S8gKG0cp1XeRJbuDWN9gxiOVz5jjFsV0bmv4B8ZKfVoEcjYjBJrZ10sx1mhhXDGt9pct2sKJvlYeivvcVPupN7zJ7Y8Xmnh7v2CF5xbiumEIg59I09HxX6nkeTs498t0tJqIxilLl+ewHSHqbuuIbdV+6F3tEwNX9p+KKf0hoT/28G3VitkqCiZWSJIAnZTvPcm/kWbrxTiv5szXt4oeB4Zc+ymVP19y5L3Mz6JJV6jcfMoZ47AseXraEKgquwdj6+lkAUPRXzrWiSpQl9gM8mDPfZ2CTo5BdjllV4J0Nn4UPDXbeFL9SA9WxCmW+N/bsyN/HYuDxILKI6QF1qg==;5:VOAe7GXS1c6cTCa7014hADaJsbS0a8YurnoYam2qv0yNymOzp6WtAg5pNf3159kRvHs5c81JohNvsvNdOr50pRwDn2vr/OGtzuVx4eUrfVLzvyzGQ/JDR3AyDUPntSECBurc8sLt/Rzx80LiGG7A3Q==;24:cRgS3plKfdrhkAsytuqGaGAhAAx/U4XgNjus3e3FIJvm/bWo9oFARI7fjVT+nD0jORAwZW2QZNeQSVUFlUjafQhv9+YlNgHQWesfVNccMTg=;7:bvxW7hoiYsh4lkW9tAqNecA4cZ4aNEMC3mkAL12VBi2jtYg/CQ+khl31I1zX1G4WcOyXqEHaKK4pnLm1kvSUK2WtWOhc569xgjn97zpPH/naCvl2+9DFXt5pf30H6aQ4AzQFanHDYDYNFulEqbfuNLU8rxxbd+lrAYNx0cT74oL807B0rUdHp5rNErOa7b0+zrqv2U4fuv5FpZFK8d46LMbjGTlzz/DDJBL9g7wej18= x-ms-office365-filtering-correlation-id: b7050986-c53a-4946-459b-08d4e357688a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603142)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0184; x-ms-traffictypediagnostic: CY4PR21MB0184: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ttalpey@microsoft.com; x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0184;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0184; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(13464003)(189002)(377454003)(199003)(1511001)(7696004)(2906002)(66066001)(2900100001)(8936002)(8676002)(81166006)(81156014)(10290500003)(86612001)(2201001)(86362001)(25786009)(3660700001)(3280700002)(2501003)(478600001)(8990500004)(102836003)(6116002)(5005710100001)(3846002)(101416001)(53936002)(6246003)(54356999)(74316002)(33656002)(105586002)(5660300001)(106356001)(229853002)(2950100002)(7736002)(189998001)(97736004)(99286003)(55016002)(10090500001)(305945005)(76176999)(68736007)(6436002)(6506006)(77096006)(50986999)(53546010)(14454004)(9686003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0184;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 20:59:50.4134 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0184 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EL04TF002992 Content-Length: 877 Lines: 24 > -----Original Message----- > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > owner@vger.kernel.org] On Behalf Of Long Li > Sent: Wednesday, August 2, 2017 4:11 PM > To: Steve French ; linux-cifs@vger.kernel.org; samba- > technical@lists.samba.org; linux-kernel@vger.kernel.org > Cc: Long Li > Subject: [[PATCH v1] 22/37] [CIFS] SMBD: Implement API for upper layer to > receive data to page > > /* > + * Read a page from receive reassembly queue > + * page: the page to read data into > + * to_read: the length of data to read > + * return value: actual data read > + */ > +int cifs_rdma_read_page(struct cifs_rdma_info *info, > + struct page *page, unsigned int to_read) > +{ Same comment as for cifs_rdma_write() - this name is confusing as it does not perform an RDMA Read. Needs to be changed. Tom.