Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbdHNVAO (ORCPT ); Mon, 14 Aug 2017 17:00:14 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35593 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752586AbdHNU76 (ORCPT ); Mon, 14 Aug 2017 16:59:58 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: References: From: Paul Moore Date: Mon, 14 Aug 2017 16:59:55 -0400 Message-ID: Subject: Re: [PATCH 0/4] SELinux: Fine-tuning for some function implementations To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Alexey Dobriyan , Daniel Jurgens , Eric Paris , James Morris , Junil Lee , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 31 On Sun, Aug 13, 2017 at 10:43 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 13 Aug 2017 16:25:43 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (4): > Delete eight unnecessary variable assignments > Adjust jump targets in ebitmap_read() > Delete an unnecessary return statement in ebitmap_destroy() > Adjust five checks for null pointers Hi Markus, I merged many of your patches in the past because I wanted to help encourage your involvement, but you will remember I mentioned at the time that I generally dislike merging these trivial, and often style-only, patches. I believe I even pointed you in the direction of our SELinux kernel issue tracker for a list of areas where you could help contribute in a meaningful way (link below). My earlier comments still apply; if you want to continue to contribute to SELinux in the kernel, please focus your attention on more meaningful changes. I am not going to merge any of these patches. * https://github.com/SELinuxProject/selinux-kernel/issues -- paul moore www.paul-moore.com