Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752533AbdHNVG5 (ORCPT ); Mon, 14 Aug 2017 17:06:57 -0400 Received: from mail-by2nam01on0114.outbound.protection.outlook.com ([104.47.34.114]:5580 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752282AbdHNVGz (ORCPT ); Mon, 14 Aug 2017 17:06:55 -0400 From: Tom Talpey To: Long Li , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive protocol Thread-Topic: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive protocol Thread-Index: AQHTC8wm7lB8Utcae0ODMR9ujAZfvKKEad1Q Date: Mon, 14 Aug 2017 21:06:53 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-25-git-send-email-longli@exchange.microsoft.com> In-Reply-To: <1501704648-20159-25-git-send-email-longli@exchange.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [24.218.182.144] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0167;6:ab9VQywApPn5AK0Y4X9d5v228Ulnvwid113bklpYz96+e56v7bCIMRKIPZsuQJRrxCVfP4WTIly9xtdTHePtjIBKfj120jZiViS2xQbKyW4aRDAv99SZJGJJ2yVTBbS8kFT4tDk3Abmw+yHkrMfw7rQG2fRjWYagrGnv49t5P3zwGEKT+CmMTF9A0/JOeDDM9bd7wVlVe6aMb7KhQ3f//IQ2gEamYXWI7VbVjwbpLTgYK+ot52eIPWY9hzuSg7iPIwDSpNnETrw7l2F0Y3WQq9USGEShQizpPKCdWn9Z9KxYCtqHTg+KmjkifXy10yX4PmeVHSzpPaM+WABQjGgjWg==;5:3oYW0HF7LKLYchnlAagOPQRERr3rJPnIsi+wScLZLHKgpQuiiQcoO4GID7ffUrkVvyMxnrJ/U41DtCuH2xoqtUQtN6c1/TXotYOKQDjYB+IO3o7BxG1nEAm+ZbsuCz+fMPpWFCMZx7FlzDJHfQm+GA==;24:F3vmeFND645kePgEESct1iJPDwrkuZlDRoO19QZMiJKaEgtYQE8K3R5RS/MY+GPrMhP5cZ4YYwCSGbSIy/CUvyLKguvgVM19ZruG+bJ8Q5s=;7:3KZSc02owjRg+oFxXP6ZP4ptvZa1+Lz6KDg5ekLV1UCsfRckmDOaPIqiSgJF5jJW2teyy1b6NJOQpImqtmudhUcZ01q1uoc2Gpb6bf7nmIalIssU45vsl2tNcryJZ8OP+rlKRBWv33ziPCfpeBTjnN7py+B35Dq6RiLqF3yDBdoPcxM8peE1ogehQf6yhw5AzgzTkuQytH40lwYWUiCgxUE3iZY1lUAbIKU2HaKVYkU= x-ms-office365-filtering-correlation-id: 43fb018e-87d2-48da-11e6-08d4e35863fb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603142)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0167; x-ms-traffictypediagnostic: CY4PR21MB0167: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ttalpey@microsoft.com; x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0167;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0167; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(189002)(199003)(13464003)(377454003)(2950100002)(68736007)(2900100001)(10090500001)(1511001)(101416001)(305945005)(106356001)(105586002)(2906002)(33656002)(3280700002)(10290500003)(3660700001)(478600001)(6436002)(7736002)(74316002)(99286003)(6246003)(53936002)(55016002)(9686003)(6506006)(189998001)(5005710100001)(8990500004)(8936002)(25786009)(66066001)(229853002)(97736004)(77096006)(3846002)(6116002)(102836003)(7696004)(8676002)(81166006)(81156014)(5660300001)(2201001)(14454004)(2501003)(50986999)(76176999)(54356999)(86612001)(86362001)(53546010);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0167;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 21:06:53.8389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0167 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EL73Fk003025 Content-Length: 1050 Lines: 25 > -----Original Message----- > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > owner@vger.kernel.org] On Behalf Of Long Li > Sent: Wednesday, August 2, 2017 4:11 PM > To: Steve French ; linux-cifs@vger.kernel.org; samba- > technical@lists.samba.org; linux-kernel@vger.kernel.org > Cc: Long Li > Subject: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive > protocol > > SMBD uses a keep alive protocol to help peers detect if the remote is dead. > When peer request keep alive, the transport needs to respond accordingly. The keepalive exchange is also used to replenish credits in certain pathological conditions. > + // send an emtpy response right away if requested > + if (le16_to_cpu(data_transfer->flags) | > + le16_to_cpu(SMB_DIRECT_RESPONSE_REQUESTED)) { > + info->keep_alive_requested = KEEP_ALIVE_PENDING; > + } This is clearly a typo, the condition is always true. "&"?? Tom.