Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbdHNVMd (ORCPT ); Mon, 14 Aug 2017 17:12:33 -0400 Received: from mail-bl2nam02on0134.outbound.protection.outlook.com ([104.47.38.134]:15118 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752556AbdHNVMb (ORCPT ); Mon, 14 Aug 2017 17:12:31 -0400 From: Tom Talpey To: Long Li , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" CC: Long Li Subject: RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection timer Thread-Topic: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection timer Thread-Index: AQHTC8w1dwfWYewARk2rHr9arncB7KKEazng Date: Mon, 14 Aug 2017 21:12:29 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-26-git-send-email-longli@exchange.microsoft.com> In-Reply-To: <1501704648-20159-26-git-send-email-longli@exchange.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [24.218.182.144] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0694;6:e0u2AxlW0d3x3WnqFTflTAFXjTJQksrSpVwICeih1j5d8J96xq2HhUrakLb1z/lbelhnOdclsuUCgUWYX/uzcOVT+gfYqNgXT6/ZVG+hso4TLLpwo6IJNqCEPeBKXlSYhGNM1v0+p01oFolNrwFNYypNM3Jv/R6u+2oBRBGytBU/hbqwGoPzKYu85Xf20uq9EJDUpI5UWxIHkhpeoAY2feH4dKUZmy6q+A3+O4QPcgHgmDATL6jLrC/YZClnk0rj59BCfVhOZnL8/iQlnYgjCaPzDqDan8LgoE4VXJo2pvcSwlfOgOeO/ZJTi5WSkUuNQGRPEw6cXL5GKF1kq0SFNQ==;5:wk/vdvmyr/V01jkd8BpB9l0DQPq3vH5zefe4JpAGLiiRxGSyuZLHqzyTSwipx/m6K/Q4BvfhkRH7pUzaHtcr566N8cfvir36KgV9pKSU+qLhiCrgpNndViOcoWBg9PJ72vSQ59qehNMjaWC4ovK66g==;24:uCs7dRu3wRWpG+MeqSET5FMK14lpqbtm9mQ0PwJ/5eImY8dtB8PWkIJeaQRSRG18Zi2B1KLZ+I200QUFdTI2UiCUAT5wSzjHP/MqGapObIg=;7:3zOp+A2leQqQ9sh2Gf0Fz8J5UZH3FAjXSC/AUNw9CJDMHDdVZ5x/LcXyx7DhHgp11tVy8k8B4WfIkOC5px3BG+tQrV9H1dRpTeIw+r0HLwOIM87QNHI7QAHlQyF8M2L+atZcTTNaKhISS2WMmC0n5VpGkAoe9D4MDLJXW1vt3TDrQtTSWGA4jHfkUz6trvwoWdgoNBvN50paj8WSFooZGwdwnXwslpANVIJd9tHeXc8= x-ms-office365-filtering-correlation-id: c7b91661-ceac-433c-d42c-08d4e3592bc9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603142)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0694; x-ms-traffictypediagnostic: CY4PR21MB0694: x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0694;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0694; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(199003)(189002)(377454003)(13464003)(76176999)(3846002)(54356999)(50986999)(106356001)(102836003)(6116002)(101416001)(105586002)(74316002)(107886003)(6246003)(14454004)(189998001)(2950100002)(4326008)(229853002)(8990500004)(7736002)(5005710100001)(6506006)(81156014)(81166006)(8676002)(8936002)(77096006)(6436002)(2906002)(3280700002)(9686003)(33656002)(3660700001)(53936002)(25786009)(55016002)(305945005)(10090500001)(10290500003)(478600001)(99286003)(68736007)(5660300001)(53546010)(86612001)(1511001)(86362001)(2900100001)(66066001)(2201001)(2501003)(7696004)(97736004);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0694;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=ttalpey@microsoft.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 21:12:29.0761 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0694 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7ELCcUi003061 Content-Length: 1096 Lines: 27 > -----Original Message----- > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > owner@vger.kernel.org] On Behalf Of Long Li > Sent: Wednesday, August 2, 2017 4:11 PM > To: Steve French ; linux-cifs@vger.kernel.org; samba- > technical@lists.samba.org; linux-kernel@vger.kernel.org > Cc: Long Li > Subject: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection timer > > +static int keep_alive_interval = 120; This is the recommended value, but not the only possibility. > @@ -1348,6 +1369,10 @@ struct cifs_rdma_info* cifs_create_rdma_session( > init_waitqueue_head(&info->wait_send_queue); > init_waitqueue_head(&info->wait_reassembly_queue); > > + INIT_DELAYED_WORK(&info->idle_timer_work, idle_connection_timer); > + schedule_delayed_work(&info->idle_timer_work, > + info->keep_alive_interval*HZ); > + This initialization is ok, but the timer should be rescheduled (extended) any time any packet is sent. There is no need to perform keepalives on an active SMB Direct connection. Tom.