Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbdHNWvH (ORCPT ); Mon, 14 Aug 2017 18:51:07 -0400 Received: from mail-by2nam03on0121.outbound.protection.outlook.com ([104.47.42.121]:33872 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752533AbdHNWvF (ORCPT ); Mon, 14 Aug 2017 18:51:05 -0400 From: Long Li To: Tom Talpey , Christoph Hellwig CC: Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 16/37] [CIFS] SMBD: Post a SMBD message with no payload Thread-Topic: [[PATCH v1] 16/37] [CIFS] SMBD: Post a SMBD message with no payload Thread-Index: AQHTC8uqbEKpSMZ5fEqLyDRWUiu4B6KCJQUAgAIWo9CAAAvWAIAAQC4Q Date: Mon, 14 Aug 2017 22:51:03 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-17-git-send-email-longli@exchange.microsoft.com> <20170813102412.GH17287@infradead.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-14T15:51:01.9739619-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:2::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0120;6:8ujJ02qFK/3KjvUCg5GrU4BaWImTchc//UygK1OI/ptF6khxb5Syy//3Y6efzlkzY3ASqGLfFkW8IfQEpHyK6ZncoQwRzfWa4KQ7Z+DYuxuUiLEhSF8pJbJX2KgALp3AG3iNT+z10LAN24nhHfhtrObvnYcvZtMJX4vHsNQuTkb398yI87tZ0t7HgKM7E7uP3hjAh8XFcC82C3uHnEJYwTvg4nBaZSeUIEEuegmC8vGHgzW8tgrvMshL/KT7N1Bdix3q8tsO54cSZb+97pbOJgv1TBb19R5pnva5EmtPnnKWb0+yhZf2xrgzTehhEEVwHpaJujQeF3kSg/sfDtUrNQ==;5:b17Tpu5L6aGbnznTGR3CgzUKiuYQ+e1i5oznIu0FmotnPOR7JM6frK8yK/k5C/s3F+TtTArRC6dQXz+54Veb7OO0tFCGVGZhU8IRWQaY5Ubmxt581MDJ72IwMcsED8oURuo2JnBUZ7JP2DZpwn5VzQ==;24:lX3cy7CnO7NK/uXQx1+Ifs3mTJW3i9Vu6U4Ze+ulw5j3b937MYarlJhTTKKXVdWs6jGN84orr1c/F5i9ciq7ync5B25onsPTnAcbVm3gvcA=;7:QVTE3DWqhVIRZ2eWhNFweZkWrmyxMQ6oIUXGSU13fDeEms2aXXSCxmscAOVwd4ttuh5EEn4Ul/xGKw4SVd7I5BTbNBJ5tn4rQkdnjskMWBdN3wt4w6c8IQsYmYMEQ1O3MVWDU04H8O5GGwdhnB3uV8Xaoc1YMEGOOXdzSI1XSki5+h1/sFvS8xoYana6xg78NQSfmwWVACY6c1HqmBrurjhAG/7DoB5Mwyprt2S8ED0= x-ms-office365-filtering-correlation-id: 045fa413-de57-4c53-481a-08d4e366f135 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603143)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0120; x-ms-traffictypediagnostic: CY4PR21MB0120: x-exchange-antispam-report-test: UriScan:(158342451672863)(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0120;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0120; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(199003)(13464003)(377454003)(189002)(305945005)(7736002)(2900100001)(97736004)(7696004)(6506006)(33656002)(4326008)(77096006)(1511001)(81156014)(81166006)(8676002)(10290500003)(106356001)(99286003)(55016002)(54906002)(5005710100001)(8990500004)(8936002)(105586002)(2421001)(189998001)(2561002)(3660700001)(14454004)(2906002)(25786009)(93886004)(3280700002)(68736007)(9686003)(2950100002)(6436002)(53546010)(50986999)(54356999)(76176999)(101416001)(74316002)(6246003)(5660300001)(102836003)(229853002)(6116002)(53936002)(10090500001)(478600001)(15650500001)(86612001)(86362001)(226483002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0120;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 22:51:03.7490 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0120 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EMpCed010460 Content-Length: 1817 Lines: 48 > -----Original Message----- > From: Tom Talpey > Sent: Monday, August 14, 2017 12:00 PM > To: Long Li ; Christoph Hellwig > Cc: Steve French ; linux-cifs@vger.kernel.org; samba- > technical@lists.samba.org; linux-kernel@vger.kernel.org > Subject: RE: [[PATCH v1] 16/37] [CIFS] SMBD: Post a SMBD message with no > payload > > > -----Original Message----- > > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > > owner@vger.kernel.org] On Behalf Of Long Li > > Sent: Monday, August 14, 2017 2:20 PM > > To: Christoph Hellwig > > Cc: Steve French ; linux-cifs@vger.kernel.org; > > samba- technical@lists.samba.org; linux-kernel@vger.kernel.org > > Subject: RE: [[PATCH v1] 16/37] [CIFS] SMBD: Post a SMBD message with > > no payload > > > > > > Implement the function to send a SMBD message with no payload. > > > > This is > > > required at times when we want to extend credtis to server to have > > > it continue to send data, without sending any actual data payload. > > > > > > Shouldn't this just be implemented as a special case in the version > > > that posts data? > > > > It uses a different packet format "struct smbd_data_transfer_no_data". > > I can restructure some common code to share between packet sending > functions. > > The SMB Direct keepalive is just a Data Transfer Message with no payload > (MS-SMBD section 2.2.3) and the SMB_DIRECT_RESPONSE_REQUESTED flag > possibly set. I don't see any need to define a special structure to describe > this? Data Transfer Message has the following extra fields at the end of an empty packet. __le32 padding; char buffer[0]; I agree with you those can be merged to a special structure case. Will make the change. > > Tom.