Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986AbdHNWx4 (ORCPT ); Mon, 14 Aug 2017 18:53:56 -0400 Received: from mail-co1nam03on0105.outbound.protection.outlook.com ([104.47.40.105]:22752 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752667AbdHNWxy (ORCPT ); Mon, 14 Aug 2017 18:53:54 -0400 From: Long Li To: Tom Talpey , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 01/37] [CIFS] SMBD: Add parsing for new rdma mount option Thread-Topic: [[PATCH v1] 01/37] [CIFS] SMBD: Add parsing for new rdma mount option Thread-Index: AQHTC8uilN+XwbS4bke04lr1XKx96aKESkQAgAA9yRA= Date: Mon, 14 Aug 2017 22:53:51 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-2-git-send-email-longli@exchange.microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-14T15:53:50.6222208-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:2::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0165;6:AVDwEC0D10enS/nqJtJghLPDMTKrLwIIu9Z6mMTZj2BCzWO4Fb7IH8a3hmur59qzyiyZaR5E5p8q3wbYqIc3hBSz4XQjU0MvmSZitdQYx+G4ObfH4NW8hlzqK7Un5muXwO8aqyq3tdR1Npw3zTh7G8K2IadYcOg9p1L+b+zxyDR/UPPo19ty0bI1LAiKeb7A3mVG17hlT0lBL93ZcW/RnhdwuxU+tP3JSa5niTtBoaeJqpliac8BbhlBK/RySdkXi62dfCyLXJ/OON9zmq80ndNHUh2wePH6kYlUrBy7vOYBuhbO7+OaLai11RhnYp8GwE1gWhe2POE8kN67YqJyGg==;5:x0S+2M4ZL7qofpRO4D82lSqgewk65bBTMAW2bgPw6sJGyh1vHj/z981/OnFpO3ean4mcM9xN145VfiHEi+jKHLP+KY1tOnR2khI8+muNtyP7+4+tX7SGfblBOdZDtevq8USlJkMGJE/bJOEqH/HFMQ==;24:EvGYjrKsQPdab9OMd1lP6416L1msY5c9n21CH+Mu6vPLC+xKVMX7uD0iUYKPzAJ3DlmN3VO4lJsq2+6+959hCExn3WgnkapxiS8cOAE/C7Q=;7:u/3w1156+lr/8TGwNFd6iVCebZg/Ux8mp/5qSZGq+gF7z7yVpFrU4lUUX+g1aeHky3xT3amx0acNJfuql28MgV2Q+ZOllk6tTz4+A/yLewW/gSfAZE3l2f+Hb8dMNmcbNGq9FFNMxouAjspuhN/q7yqjrY1Vb8r29pohoxzJe2Ns9+pFdcKa8CxkxFvMn3QI8dNQ+2bN9NmMu8pMf/YDe+OLneOGpmEDNaPDmRPfrrs= x-ms-office365-filtering-correlation-id: 1a8e608d-7e98-484f-da18-08d4e3675589 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603143)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0165; x-ms-traffictypediagnostic: CY4PR21MB0165: x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0165;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0165; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(13464003)(377454003)(189002)(199003)(106356001)(1511001)(8936002)(105586002)(8676002)(305945005)(81156014)(81166006)(7736002)(2421001)(5005710100001)(8990500004)(86612001)(14454004)(76176999)(101416001)(2561002)(86362001)(2501003)(54356999)(50986999)(33656002)(229853002)(6116002)(102836003)(5660300001)(6506006)(7696004)(77096006)(10090500001)(3280700002)(3660700001)(2201001)(2906002)(6436002)(68736007)(74316002)(2950100002)(10290500003)(53936002)(55016002)(99286003)(9686003)(97736004)(478600001)(6246003)(2900100001)(189998001)(25786009)(53546010)(21314002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0165;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 22:53:52.0910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0165 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EMs0dN010503 Content-Length: 1395 Lines: 37 > -----Original Message----- > From: Tom Talpey > Sent: Monday, August 14, 2017 12:10 PM > To: Long Li ; Steve French ; > linux-cifs@vger.kernel.org; samba-technical@lists.samba.org; linux- > kernel@vger.kernel.org > Subject: RE: [[PATCH v1] 01/37] [CIFS] SMBD: Add parsing for new rdma > mount option > > > -----Original Message----- > > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > > owner@vger.kernel.org] On Behalf Of Long Li > > Sent: Wednesday, August 2, 2017 4:10 PM > > To: Steve French ; linux-cifs@vger.kernel.org; > > samba- technical@lists.samba.org; linux-kernel@vger.kernel.org > > Cc: Long Li > > Subject: [[PATCH v1] 01/37] [CIFS] SMBD: Add parsing for new rdma > > mount option > > > > From: Long Li > > > > When doing mount with "-o rdma", user can specify this is for > > connecting to a SMBD session. > > Nit: it's an "SMB" session. SMBD (SMB Direct) is the transport connection. > > The use of SMB Direct is only applicable when an SMB3.x dialect is negotiated. > Is there any restriction in the use of the mount option to preclude also > specifying > SMB1 and SMB2.x? SMB version is specified in mount "-o vers=XXX". For example, "mount -o vers=3.02" will try to negotiate SMB 3.02. I will make the change to return error on vers<3. > > Tom.