Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbdHNW6O (ORCPT ); Mon, 14 Aug 2017 18:58:14 -0400 Received: from mail-dm3nam03on0136.outbound.protection.outlook.com ([104.47.41.136]:21473 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752619AbdHNW6M (ORCPT ); Mon, 14 Aug 2017 18:58:12 -0400 From: Long Li To: Tom Talpey , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 14/37] [CIFS] SMBD: Post a SMBD data transfer message with page payload Thread-Topic: [[PATCH v1] 14/37] [CIFS] SMBD: Post a SMBD data transfer message with page payload Thread-Index: AQHTC8upiKPvgHmXX0S++idTJ6HGaKKEXreAgAArNRA= Date: Mon, 14 Aug 2017 22:58:09 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-15-git-send-email-longli@exchange.microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-14T15:58:07.9623577-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:2::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0184;6:I0K4u/H8EbwpqteOjlxHxDLnWhXiLMpWEIu0DD6zB1rx3hgj8t3DGhb3Pq7QbsmbIYgLW0uyx2xEhd4zB5dPYtwo2eSYBkxrxBhy2m5JvH43eBTmx33NJNzU9mKpCa2UsOFAQUxCEJ1L/UjoUrZ02WXUYyJ2vlbg734oL4Dyta7pLMBNT7ftTCKSInUm1x961zcxgqsc86bShEUSZlE5Ce1FxW1LFbMHYo1MBi1BPSkg5iRQ/c62XQakCp3xwj7aAKyknh0Gdi1NCjyPKhu1xiCzTUpz1OjJy5ZZVB7vQlon6W+WiaM0yR5uwdM8YLcbTMK8CszRP8QOWAhVkFfi1Q==;5:ELVtqL2UoTGn7EVxMq6OcQjVtO+Ft++MuYyzcxo0fd5kZMe0en1fEwch3kCTeFPXBsOX4N5qOCml2Cx2hjL8uOObrjvpp6iqD3R0lwmoP540bjjPCYVKobbr9/0cKiErc5QW9JQD/bqASA6YtE7Zww==;24:jO1x/n11JfhJOhgYsbd1crlmODfFFBydHM2hl8E2rA8aAbe0jUB4QQOumIriR7rQL53BKFYG8NHMB14Mox/Xb+cL0hZmMHSaM6IF/vf1TXQ=;7:hBrWu13zrrB6M5XuyAmeLgmt04uKZ+sMg7AaI6eYsaoZHW86/KmGxxGiwFe7cf3N21Ajl8pNbb8KiQbcro5voXZvFiqHiJzszgnss4bMG2kV+dZsKkLn4qlF8Tgexxr/0tY/MGadk3TBzcM48Zb+BFq5hcYMmIe8Ie2pQTEZD6lZQ0pheUCE4lhlGwKePjFRLu+/LUxFKESDsqc391EE0S67gGhKHEo1YmnFgFDMeXY= x-ms-office365-filtering-correlation-id: 846ac3e7-f338-4c88-f664-08d4e367eef6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603143)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0184; x-ms-traffictypediagnostic: CY4PR21MB0184: x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0184;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0184; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(199003)(377454003)(13464003)(189002)(2950100002)(86612001)(10290500003)(7696004)(86362001)(101416001)(15650500001)(33656002)(6246003)(6436002)(478600001)(2201001)(2421001)(25786009)(77096006)(6506006)(10090500001)(97736004)(229853002)(74316002)(6116002)(102836003)(5660300001)(2900100001)(106356001)(105586002)(217423001)(2561002)(8990500004)(5005710100001)(53936002)(2501003)(8676002)(50986999)(53546010)(76176999)(189998001)(54356999)(81166006)(81156014)(8936002)(305945005)(1511001)(7736002)(9686003)(68736007)(2906002)(14454004)(3660700001)(99286003)(3280700002)(55016002)(226483002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0184;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 22:58:09.5444 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0184 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7EMwJtK010522 Content-Length: 1625 Lines: 46 > -----Original Message----- > From: Tom Talpey > Sent: Monday, August 14, 2017 1:23 PM > To: Long Li ; Steve French ; > linux-cifs@vger.kernel.org; samba-technical@lists.samba.org; linux- > kernel@vger.kernel.org > Subject: RE: [[PATCH v1] 14/37] [CIFS] SMBD: Post a SMBD data transfer > message with page payload > > > -----Original Message----- > > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > > owner@vger.kernel.org] On Behalf Of Long Li > > Sent: Wednesday, August 2, 2017 4:10 PM > > To: Steve French ; linux-cifs@vger.kernel.org; > > samba- technical@lists.samba.org; linux-kernel@vger.kernel.org > > Cc: Long Li > > Subject: [[PATCH v1] 14/37] [CIFS] SMBD: Post a SMBD data transfer > > message with page payload > > > > /* > > + * Send a page > > + * page: the page to send > > + * offset: offset in the page to send > > + * size: length in the page to send > > + * remaining_data_length: remaining data to send in this payload */ > > +static int cifs_rdma_post_send_page(struct cifs_rdma_info *info, > > +struct page > > *page, > > + unsigned long offset, size_t size, int > > +remaining_data_length) { > >... > > + wait_event(info->wait_send_queue, > > + atomic_read(&info->send_credits) > > > 0); > > This is an uninterruptible wait, correct? What's to guarantee the event will > ever fire? Also, if the count is zero, there should be a check that an SMB > Direct credit request is outstanding. If not, it's wasteful to sleep for the > keepalive timer to do so. Will fix it. > > Tom.