Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbdHNX1P (ORCPT ); Mon, 14 Aug 2017 19:27:15 -0400 Received: from mail-bl2nam02on0094.outbound.protection.outlook.com ([104.47.38.94]:23283 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752643AbdHNX1M (ORCPT ); Mon, 14 Aug 2017 19:27:12 -0400 From: Long Li To: Tom Talpey , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive protocol Thread-Topic: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive protocol Thread-Index: AQHTC8uqHTPoRi7wv0u6LSPAopGhGaKEauqAgAAnAzA= Date: Mon, 14 Aug 2017 23:27:00 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-25-git-send-email-longli@exchange.microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-14T16:26:59.2128667-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:2::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0472;6:vRHDjH2WECPT36q93D8MMuYGDNPxNG8M7kdHlY6mAtjzl/i4NTMNuD6SIgB5eKajLDI1VO1+OyUhL7KBejd5nYwIbbg+AWJev3tBanGUDcIRb9nt0vr09Xkq+X8XySP3VdIRsv135V4R//Yw0DEWGuhWyRKATO7EOP7ihrM9k+pbgg1kxmzHYMHxQYx8XXePZaw1UyVGs8EBwvcsf90XNE3E5eH/+DD6sz6sTlq2EUmfxH+o2YGv3aOhj3eMUSAqytrjYkpIW+CSDVhvoA/chAN4IoMkJYZZm+LWlHYVbee8RDoBneFvhjWPiA5IWyMJgB4qhD4BfnKtjry85AV42A==;5:9Q00vy+wFBg08GK89fARVoM57f/lQsTPqRJ2t7nF6KnAwMAW2MCcQyeeWHp3ArOQVg9z7m1QmjUZSgUYFdSz3wF9cgx77Sr0SiHdxNTgtw75Np8F2KQWw1+C7xoGauRr93ZVFmithq20KqpBkgMqFA==;24:oF5IAZ57H3fEm/bkRY9q6DaiEds7Wvge9rby1pM8fT+QbN1QJ/1XDiA+E0IxNCRACig/HttubuljPo2ZP7DGUWitkWveTKkduWpFDfjloF4=;7:73xQlk3mR2jQ6muXeLIJFNkEYhz8Pgve08CjHUKdJ2GrkWPzVotk97mEEe3Mcw9ldYjpSYjHX1StMFjwP0WLWT0OiLWzbEYO4EONMPsb2t2azfW7ZiZcsPBDVjy6u5XvHVcJbNT9HG6iAQDYhwFT1+VgrM4xZTl/DMwLFp3rI+8Hf3v5ivW8aytIqV39qazn/BVhuuM61DKJwU/oc+HnFjPoeGeB7K5F0w2qBSJcqlI= x-ms-office365-filtering-correlation-id: bbeb314e-80ec-4c52-c8c0-08d4e36bfc4f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603143)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0472; x-ms-traffictypediagnostic: CY4PR21MB0472: authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0472;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0472; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(189002)(13464003)(377454003)(199003)(7736002)(77096006)(10090500001)(2421001)(33656002)(53546010)(99286003)(6506006)(55016002)(305945005)(25786009)(105586002)(106356001)(14454004)(8676002)(81166006)(81156014)(68736007)(54356999)(76176999)(50986999)(8936002)(101416001)(7696004)(5660300001)(9686003)(6436002)(229853002)(6246003)(97736004)(2501003)(5005710100001)(8990500004)(2561002)(2900100001)(3660700001)(10290500003)(3280700002)(478600001)(86612001)(86362001)(102836003)(6116002)(2201001)(6666003)(2950100002)(74316002)(53936002)(2906002)(1511001)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0472;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 23:27:00.5495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0472 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7ENRJ69010607 Content-Length: 1467 Lines: 39 > -----Original Message----- > From: Tom Talpey > Sent: Monday, August 14, 2017 2:07 PM > To: Long Li ; Steve French ; > linux-cifs@vger.kernel.org; samba-technical@lists.samba.org; linux- > kernel@vger.kernel.org > Subject: RE: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive > protocol > > > -----Original Message----- > > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > > owner@vger.kernel.org] On Behalf Of Long Li > > Sent: Wednesday, August 2, 2017 4:11 PM > > To: Steve French ; linux-cifs@vger.kernel.org; > > samba- technical@lists.samba.org; linux-kernel@vger.kernel.org > > Cc: Long Li > > Subject: [[PATCH v1] 24/37] [CIFS] SMBD: Support for SMBD keep alive > > protocol > > > > SMBD uses a keep alive protocol to help peers detect if the remote is dead. > > When peer request keep alive, the transport needs to respond accordingly. > > The keepalive exchange is also used to replenish credits in certain > pathological conditions. > > > + // send an emtpy response right away if requested > > + if (le16_to_cpu(data_transfer->flags) | > > + le16_to_cpu(SMB_DIRECT_RESPONSE_REQUESTED)) { > > + info->keep_alive_requested = KEEP_ALIVE_PENDING; > > + } > > This is clearly a typo, the condition is always true. "&"?? Sorry it's a typo. > > Tom.