Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbdHNXbB (ORCPT ); Mon, 14 Aug 2017 19:31:01 -0400 Received: from mail-bl2nam02on0095.outbound.protection.outlook.com ([104.47.38.95]:65168 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752651AbdHNXa7 (ORCPT ); Mon, 14 Aug 2017 19:30:59 -0400 From: Long Li To: Tom Talpey , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to Makefile Thread-Topic: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to Makefile Thread-Index: AQHTC8ursUxnazljgUeUT48RYOFbLqKEbpWAgAAkfcA= Date: Mon, 14 Aug 2017 23:30:56 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-31-git-send-email-longli@exchange.microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-14T16:30:55.6233711-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:2::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0504;6:e+0Pujx5aA2ps6uJ6VM9PKohgkXIlbnxjMtLhFLV5MlB7VcD5TQ8K1A8LI8TCZcDQNDTyct1j+lfLsMMcvOSoiUseRm2HdPQE4LDl7SLLGdWoauvQfj8sfGMpQGuUbc08gj30oPMtA5glfg3KuyN9CvvbXuJGVJRKzLj0vYNE61kLxOJrXL0XHdORHEH3AOTDtXdTvJnC7wkEh7/DdCeMHPiyGdD3V7/p7865thx6tC7Mnx+JM4kxMYDEC72PgyOiev4Z9z6uCE7VoExSsiuAoXFt2dNOce6XoRa7ZlPhxw/LG2tnM0iHjoolW+lsbO8go169Vi3eZoGRE0BQmR4ng==;5:4rXue6WaX4liuCDXmuBffDSfc8ibP7jaS2NBueFe8/2I7minL0e3O2l+NlXc4RTPS362SRElhNwre7zAM+DYgAyDGwjO5HHzZpGhtzMND66AETdIqF8sFd379T0P63VbJShASY/pSrPYTFqoEwjEpQ==;24:NadMQR2h1Crx6odZlktvVYEJ8j9oHbLVdVSXKBVE3IP8Ibqvg3qP1bTh6AgcrZFUvfuKwOhlUtwWG0xEVqHNekNdoRosDRFsbLIyZxoxRbM=;7:Pt9INot42eYWI4q7IE3kD1gBTtiRkctYd5OKRnNVtdzJmKTaZeorEgDLvpc/iu1x6sYWoavzeWixgN31AWSwvx73pP/AmHqw34RX3cecL356b8yta9+nvn3qpkDRQdiBUM672cm6/hXudCHTZegZmhvBfp4uzn6kwsEzhOBUzS0Ul+0xWPVzwc9WCU9ArFiIQ6HpkQXTYWbTjhLf/TxqANyOdkyZ5Cgle/RYvrAqZPY= x-ms-office365-filtering-correlation-id: fe58ea78-2242-46fe-7031-08d4e36c83a5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603143)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0504; x-ms-traffictypediagnostic: CY4PR21MB0504: x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0504;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0504; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(199003)(377454003)(189002)(13464003)(68736007)(55016002)(99286003)(5005710100001)(2201001)(86362001)(8990500004)(229853002)(10290500003)(2900100001)(6116002)(102836003)(53546010)(7736002)(86612001)(1511001)(2950100002)(25786009)(9686003)(478600001)(8936002)(81166006)(8676002)(81156014)(305945005)(2421001)(2906002)(77096006)(33656002)(6246003)(106356001)(105586002)(101416001)(6436002)(3280700002)(50986999)(189998001)(53936002)(6506006)(76176999)(54356999)(3660700001)(10090500001)(2501003)(14454004)(74316002)(7696004)(2561002)(97736004)(5660300001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0504;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 23:30:56.9931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0504 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7ENV7Lu010616 Content-Length: 1431 Lines: 37 > -----Original Message----- > From: Tom Talpey > Sent: Monday, August 14, 2017 2:20 PM > To: Long Li ; Steve French ; > linux-cifs@vger.kernel.org; samba-technical@lists.samba.org; linux- > kernel@vger.kernel.org > Subject: RE: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to > Makefile > > > -----Original Message----- > > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > > owner@vger.kernel.org] On Behalf Of Long Li > > Sent: Wednesday, August 2, 2017 4:11 PM > > To: Steve French ; linux-cifs@vger.kernel.org; > > samba- technical@lists.samba.org; linux-kernel@vger.kernel.org > > Cc: Long Li > > Subject: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to > > Makefile > > > > cifs-$(CONFIG_CIFS_SMB2) += smb2ops.o smb2maperror.o > smb2transport.o \ > > - smb2misc.o smb2pdu.o smb2inode.o smb2file.o > > + smb2misc.o smb2pdu.o smb2inode.o > > + smb2file.o cifsrdma.o > > "cifsrdma.o" is a really confusing choice of names. SMB Direct is only possible > when the negotiated SMB dialect is SMB3. "CIFS" historically means a dialect > of SMB1, which many of us would like to see be in a separate, and therefore > omittable, module. Please use a name more indicative of the function, > perhaps "smbdirect.o". Yes, I will make the naming changes. > > Tom.