Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbdHNXhV (ORCPT ); Mon, 14 Aug 2017 19:37:21 -0400 Received: from mail-sn1nam01on0096.outbound.protection.outlook.com ([104.47.32.96]:42952 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752692AbdHNXhU (ORCPT ); Mon, 14 Aug 2017 19:37:20 -0400 From: Long Li To: Tom Talpey , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 23/37] [CIFS] SMBD: Implement API for upper layer to reconnect transport Thread-Topic: [[PATCH v1] 23/37] [CIFS] SMBD: Implement API for upper layer to reconnect transport Thread-Index: AQHTC8uq9562GQHNfEGm5Fmcgn7xnKKEabKAgAAqyBA= Date: Mon, 14 Aug 2017 23:37:17 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-24-git-send-email-longli@exchange.microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-14T16:37:16.7019825-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:2::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0150;6:9KBOZaQLIbKw9NXy7rDu3mqmB4iwabchls2HS63pluySzxJO2s1sJGGYxhOKECW3ROXQk3AjZcOrLBaRBUblgFOYeRqVucPtJsE5dTH84ZDYWg+DX70hh7V2X4YLOs3XgZRuEOjhxTUrSljip2R5hUeMnI/GxOBpTIy6AsmaorU1p09KbGTQLUAbc8wM1kljrYGcdj2XwJRnOEpU5+zC+eQF6uEOoqT9sfHo+E8Ej5DBXOZy1mYsG6BFPAoqhtAq7p9qDpqVX5LkjYgjZCBoGIqiz1Ti3f/GjLhIPLLIA4WOZDHnPQGenIDZ5SF4VuXUXxAABsdaS32YqodQFeTJLw==;5:25Jmq9k0GHspfu+0NUvpFm7ecWdjBkQA0e0reiDaTES7UpiWa5KApP7KbQV2ffITsgLV6phzamXOxJfXQmYfVwEfzdxIdr6wU9emNYClzCRyAuheEA78aWJiO/0TAyOAncfIaZB/sW5fVttay8DJzA==;24:Hlax0n9UwAyVC1Dh7Y+ZCjSu8HkCOT5SGXUFe3EZfHxdoq/759iMaxNymaTV+Sh6eWPTJR7YBjcMuwmSmtw+tNp7eP/1OhLvj4PsgOWGRHA=;7:qG93WZiGvUOyPF7DlOQX/cIdFm5MLWsfDHsHEhwyXYsKwhhWQhc7zrk+xUUrES/SrEFZeJT57y1ZIa88VpVICSY2Z5fsP0+scc5eD9/87wH9kSwkV0Zw5zuArrsYM9E4Z0kevqBYdhDFinfdm+3pzQG1jS9+go5b1MFTZlp+s/IN9Q3TIx82Q2OMFZtqh6OHHJ9IVCf1CL/FcjJXnBc24T1HevWAoHpeTS+ufs07PZA= x-ms-office365-filtering-correlation-id: 8b890591-9738-454e-de52-08d4e36d66b5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603143)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0150; x-ms-traffictypediagnostic: CY4PR21MB0150: x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0150;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0150; x-forefront-prvs: 039975700A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(13464003)(199003)(377454003)(189002)(2561002)(9686003)(8676002)(2201001)(54356999)(76176999)(7696004)(50986999)(86612001)(14454004)(189998001)(86362001)(53936002)(6506006)(106356001)(8936002)(229853002)(77096006)(6436002)(2501003)(2950100002)(8990500004)(99286003)(55016002)(5005710100001)(2421001)(97736004)(10090500001)(105586002)(81156014)(33656002)(81166006)(2900100001)(2906002)(5660300001)(102836003)(6116002)(53546010)(74316002)(10290500003)(68736007)(478600001)(3280700002)(101416001)(25786009)(3660700001)(1511001)(6246003)(7736002)(305945005);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0150;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2017 23:37:17.8967 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0150 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7ENbPsM010639 Content-Length: 1649 Lines: 45 > -----Original Message----- > From: Tom Talpey > Sent: Monday, August 14, 2017 2:03 PM > To: Long Li ; Steve French ; > linux-cifs@vger.kernel.org; samba-technical@lists.samba.org; linux- > kernel@vger.kernel.org > Subject: RE: [[PATCH v1] 23/37] [CIFS] SMBD: Implement API for upper layer > to reconnect transport > > > -----Original Message----- > > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > > owner@vger.kernel.org] On Behalf Of Long Li > > Sent: Wednesday, August 2, 2017 4:11 PM > > To: Steve French ; linux-cifs@vger.kernel.org; > > samba- technical@lists.samba.org; linux-kernel@vger.kernel.org > > Cc: Long Li > > Subject: [[PATCH v1] 23/37] [CIFS] SMBD: Implement API for upper layer > > to reconnect transport > > > > +int cifs_reconnect_rdma_session(struct TCP_Server_Info *server) { > > + log_rdma_event("reconnecting rdma session\n"); > > + > > + // why reconnect while it is still connected? > > + if (server->rdma_ses->transport_status == CIFS_RDMA_CONNECTED) > { > > + log_rdma_event("still connected, not reconnecting\n"); > > + return -EINVAL; > > + } > > Why is this check needed? This was used in early stage of development. It's probably not needed anymore. Will look into this. > > > + > > + // wait until the transport is destroyed > > + while (server->rdma_ses->transport_status != > CIFS_RDMA_DESTROYED) > > + msleep(1); > > Polling!? Please plan to implement a proper handshake for connection logic. Will look into using wait queue.