Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752808AbdHOALB (ORCPT ); Mon, 14 Aug 2017 20:11:01 -0400 Received: from mail-cys01nam02on0129.outbound.protection.outlook.com ([104.47.37.129]:26680 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751851AbdHOAK7 (ORCPT ); Mon, 14 Aug 2017 20:10:59 -0400 From: Long Li To: Tom Talpey , Steve French , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" Subject: RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection timer Thread-Topic: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection timer Thread-Index: AQHTC8upminUdbtXWkWKXLbw7RnLfKKEbHuAgAAluwCAAAQagIAAB7tw Date: Tue, 15 Aug 2017 00:10:56 +0000 Message-ID: References: <1501704648-20159-1-git-send-email-longli@exchange.microsoft.com> <1501704648-20159-26-git-send-email-longli@exchange.microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-14T17:10:55.4571444-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:2::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR21MB0136;6:sjjVyqFZGKbtGOfcz/z5T8Q2MT6zWFtDvS3waaCtVZ4Zeuaa4UQpbjn8NYvke+t1M3SE6JafQwkRu3dC05OYJf7pVjv9c/2wdESBjMAS314M3Ed8xK6YsLDV8pDvpGU/7v67sdKIFY8LXoTSIeZWiMEvpFAu+Uj06M9SZ3LKL5RAmjd9FwnZJdiL/P/w9Q7KS3G87OionzcYKTXyFKqqpb1W0IxWcfp/Ce4ziXF4uBj+/EeG+nsppfIWEjaeI0PEBQIj9wkUer7d3qXDONRvFJugFLKU3IZYZWaic5BozXbrq4Tmci/AMbyS04hiezEteQmV7gKAbVhfHBlgLsiDFg==;5:h9vJtJiJOk6/ep4+BeiMPLG6AUM17nPZ2QcE0IULcY6BxX4EV04gTz6Sq5dtJnERHL2Tsnb6UW9ExSHM+s/6neBs9p9rbGMy7MxfzLR+I+HwoqwFMsh3ls8XxpRNFCzNJ12QPBMA7UIxN9Bxw4WqEA==;24:HGy7OXS9sjYisXqSfLNesFpFJQdWc63lG+VRgLhkXxnvucpZlCJVQsxfl7T3P6yTpRK6O/dQZf9qG3DLkmK7cFBPaA+scjpF1g6KrG0ITW4=;7:ticNSgRFicrdzgCc0JPM0d26OM31jijmz70beaoAZBzLHJv1BJ+360GkhLpMTvrdURkNlMzAnBNNOqL8ozgkHRwH2mP2N9LPnE91J0seXijUq1EfjdxNfLNGcpLhcT58BkFktjHV4wHrHCf97ekXvF4jAu/xyZiyaphIOCXwykX9YWepEp+7gTtQMizV4ENZ/RGFTlKKAP11TQAxx+YtgcShRD05QNITkXHd+0Vur/E= x-ms-office365-filtering-correlation-id: 4cbe77b5-1e82-4486-07eb-08d4e3721a13 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603143)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR21MB0136; x-ms-traffictypediagnostic: CY4PR21MB0136: authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; x-exchange-antispam-report-test: UriScan:(89211679590171)(9452136761055); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(61426038)(61427038)(6041248)(20161123558100)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR21MB0136;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR21MB0136; x-forefront-prvs: 04004D94E2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(199003)(13464003)(189002)(377454003)(1511001)(305945005)(7736002)(229853002)(478600001)(2950100002)(6506006)(77096006)(2561002)(10290500003)(2501003)(2421001)(3660700001)(3280700002)(25786009)(8676002)(2201001)(6436002)(2906002)(55016002)(99286003)(6306002)(189998001)(53936002)(9686003)(53376002)(53366004)(6246003)(86362001)(7696004)(86612001)(81156014)(2900100001)(81166006)(68736007)(101416001)(6116002)(102836003)(966005)(97736004)(93886004)(106356001)(14454004)(8936002)(5660300001)(33656002)(105586002)(76176999)(50986999)(54356999)(53546010)(10090500001)(8990500004)(5005710100001)(74316002)(10090945008);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0136;H:CY4PR21MB0182.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2017 00:10:56.7595 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0136 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7F0B5Pd014059 Content-Length: 3417 Lines: 85 > -----Original Message----- > From: Tom Talpey > Sent: Monday, August 14, 2017 4:42 PM > To: Long Li ; Steve French ; > linux-cifs@vger.kernel.org; samba-technical@lists.samba.org; linux- > kernel@vger.kernel.org > Subject: RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle connection > timer > > > -----Original Message----- > > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > > owner@vger.kernel.org] On Behalf Of Long Li > > Sent: Monday, August 14, 2017 7:30 PM > > To: Tom Talpey ; Steve French > > ; linux-cifs@vger.kernel.org; > > samba-technical@lists.samba.org; linux- kernel@vger.kernel.org > > Subject: RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle > > connection timer > > > > [This sender failed our fraud detection checks and may not be who they > > appear to be. Learn about spoofing at > > http://aka.ms/LearnAboutSpoofing] > > > > > -----Original Message----- > > > From: Tom Talpey > > > Sent: Monday, August 14, 2017 2:12 PM > > > To: Long Li ; Steve French > > > ; linux-cifs@vger.kernel.org; > > > samba-technical@lists.samba.org; linux- kernel@vger.kernel.org > > > Cc: Long Li > > > Subject: RE: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle > > > connection timer > > > > > > > -----Original Message----- > > > > From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs- > > > > owner@vger.kernel.org] On Behalf Of Long Li > > > > Sent: Wednesday, August 2, 2017 4:11 PM > > > > To: Steve French ; linux-cifs@vger.kernel.org; > > > > samba- technical@lists.samba.org; linux-kernel@vger.kernel.org > > > > Cc: Long Li > > > > Subject: [[PATCH v1] 25/37] [CIFS] SMBD: Support SMBD idle > > > > connection timer > > > > > > > > +static int keep_alive_interval = 120; > > > > > > This is the recommended value, but not the only possibility. > > > > > > > @@ -1348,6 +1369,10 @@ struct cifs_rdma_info* > > > cifs_create_rdma_session( > > > > init_waitqueue_head(&info->wait_send_queue); > > > > init_waitqueue_head(&info->wait_reassembly_queue); > > > > > > > > + INIT_DELAYED_WORK(&info->idle_timer_work, > > > idle_connection_timer); > > > > + schedule_delayed_work(&info->idle_timer_work, > > > > + info->keep_alive_interval*HZ); > > > > + > > > > > > This initialization is ok, but the timer should be rescheduled > > > (extended) any time any packet is sent. There is no need to perform > > > keepalives on an active SMB Direct connection. > > > > My feeling is that rescheduling on a work queue for every packet is > > sent is not efficient, especially under heavy conditions. > > That's not what I was suggesting. Cant the timer simply be re-extended to > the 120-second interval? I.e. on an active connection, it will never fire > because it's always advancing. > > As defined here, it will go off and send a keepalive every 120 seconds. The > idle_connection_timer() routine unconditionally sends it. > > > > > Firing it every 120 seconds doesn't seem to be big waste and may > > actually save some CPU. > > Firing the timer, no big deal. Sending the packets and requiring the peer to > process them too, disagree. Fair enough. I will fix the code to modify delayed work instead of firing every 120 seconds. > > Tom.