Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbdHOCYN (ORCPT ); Mon, 14 Aug 2017 22:24:13 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3085 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbdHOCYJ (ORCPT ); Mon, 14 Aug 2017 22:24:09 -0400 Date: Tue, 15 Aug 2017 03:23:03 +0100 From: Jonathan Cameron To: Gilad Ben-Yossef CC: Herbert Xu , "David S. Miller" , Jonathan Corbet , David Howells , Tom Lendacky , Gary Hook , Boris Brezillon , Arnaud Ebalard , Matthias Brugger , Alasdair Kergon , Mike Snitzer , , Shaohua Li , Steve French , "Theodore Y. Ts'o" , "Jaegeuk Kim" , Mimi Zohar , "Dmitry Kasatkin" , James Morris , "Serge E. Hallyn" , , , , , , , , , , , , , , Eric Biggers , Ofir Drang Subject: Re: [PATCH v5 05/19] crypto: introduce crypto wait for async op Message-ID: <20170815032303.000042b2@huawei.com> In-Reply-To: <1502724094-23305-6-git-send-email-gilad@benyossef.com> References: <1502724094-23305-1-git-send-email-gilad@benyossef.com> <1502724094-23305-6-git-send-email-gilad@benyossef.com> Organization: Huawei X-Mailer: Claws Mail 3.15.0 (GTK+ 2.24.31; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.206.48.115] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.59925B21.0095,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: eb332bed355083e81c42b9eef0823ac7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3263 Lines: 119 On Mon, 14 Aug 2017 18:21:15 +0300 Gilad Ben-Yossef wrote: > Invoking a possibly async. crypto op and waiting for completion > while correctly handling backlog processing is a common task > in the crypto API implementation and outside users of it. > > This patch adds a generic implementation for doing so in > preparation for using it across the board instead of hand > rolled versions. > > Signed-off-by: Gilad Ben-Yossef > CC: Eric Biggers One really trivial point inline I happened to notice. > --- > crypto/api.c | 13 +++++++++++++ > include/linux/crypto.h | 41 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+) > > diff --git a/crypto/api.c b/crypto/api.c > index 941cd4c..2a2479d 100644 > --- a/crypto/api.c > +++ b/crypto/api.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > #include "internal.h" > > LIST_HEAD(crypto_alg_list); > @@ -595,5 +596,17 @@ int crypto_has_alg(const char *name, u32 type, u32 mask) > } > EXPORT_SYMBOL_GPL(crypto_has_alg); > > +void crypto_req_done(struct crypto_async_request *req, int err) > +{ > + struct crypto_wait *wait = req->data; > + > + if (err == -EINPROGRESS) > + return; > + > + wait->err = err; > + complete(&wait->completion); > +} > +EXPORT_SYMBOL_GPL(crypto_req_done); > + > MODULE_DESCRIPTION("Cryptographic core API"); > MODULE_LICENSE("GPL"); > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index 84da997..bb00186 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > /* > * Autoloaded crypto modules should only use a prefixed name to avoid allowing > @@ -468,6 +469,45 @@ struct crypto_alg { > } CRYPTO_MINALIGN_ATTR; > > /* > + * A helper struct for waiting for completion of async crypto ops > + */ > +struct crypto_wait { > + struct completion completion; > + int err; > +}; > + > +/* > + * Macro for declaring a crypto op async wait object on stack > + */ > +#define DECLARE_CRYPTO_WAIT(_wait) \ > + struct crypto_wait _wait = { \ > + COMPLETION_INITIALIZER_ONSTACK((_wait).completion), 0 } > + > +/* > + * Async ops completion helper functioons > + */ > +void crypto_req_done(struct crypto_async_request *req, int err); > + > +static inline int crypto_wait_req(int err, struct crypto_wait *wait) > +{ > + switch (err) { > + case -EINPROGRESS: > + case -EBUSY: > + wait_for_completion(&wait->completion); > + reinit_completion(&wait->completion); > + err = wait->err; > + break; > + }; > + > + return err; > +} > + > +static inline void crypto_init_wait(struct crypto_wait *wait) > +{ > + init_completion(&wait->completion); > +} > + > +/* > * Algorithm registration interface. > */ > int crypto_register_alg(struct crypto_alg *alg); > @@ -1604,5 +1644,6 @@ static inline int crypto_comp_decompress(struct crypto_comp *tfm, > src, slen, dst, dlen); > } > > + Trivial observation. Shouldn't have this bonus blank line inserted here. > #endif /* _LINUX_CRYPTO_H */ >