Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbdHODY3 (ORCPT ); Mon, 14 Aug 2017 23:24:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:52482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753146AbdHODY0 (ORCPT ); Mon, 14 Aug 2017 23:24:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0193122B55 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jaegeuk@kernel.org Date: Mon, 14 Aug 2017 20:24:25 -0700 From: Jaegeuk Kim To: Yunlong Song Cc: chao@kernel.org, yuchao0@huawei.com, yunlong.song@icloud.com, miaoxie@huawei.com, bintian.wang@huawei.com, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs-tools: the overprovision should be 0 as default Message-ID: <20170815032425.GB91145@jaegeuk-macbookpro.roam.corp.google.com> References: <1502457915-46935-1-git-send-email-yunlong.song@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502457915-46935-1-git-send-email-yunlong.song@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 26 On 08/11, Yunlong Song wrote: > The usage message gives a wrong number, so fix it. > > Signed-off-by: Yunlong Song > --- > mkfs/f2fs_format_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c > index a3652a9..6712b5c 100644 > --- a/mkfs/f2fs_format_main.c > +++ b/mkfs/f2fs_format_main.c > @@ -41,7 +41,7 @@ static void mkfs_usage() > MSG(0, " -f force overwrite the exist filesystem\n"); > MSG(0, " -l label\n"); > MSG(0, " -m support zoned block device [default:0]\n"); > - MSG(0, " -o overprovision ratio [default:5]\n"); > + MSG(0, " -o overprovision ratio [default:0]\n"); We need to remove [default:xx], since the default is not fixed? > MSG(0, " -O [feature list] e.g. \"encrypt\"\n"); > MSG(0, " -q quiet mode\n"); > MSG(0, " -s # of segments per section [default:1]\n"); > -- > 1.8.5.2