Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbdHOFLX (ORCPT ); Tue, 15 Aug 2017 01:11:23 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36218 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdHOFLV (ORCPT ); Tue, 15 Aug 2017 01:11:21 -0400 Date: Mon, 14 Aug 2017 22:11:17 -0700 From: Dmitry Torokhov To: Arvind Yadav Cc: syrjala@sci.fi, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] Input: ati_remote2: constify usb_device_id Message-ID: <20170815051117.GB40695@dtor-ws> References: <8d2f77c37ab938f3b4ed124b02aff2021714e591.1502211151.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d2f77c37ab938f3b4ed124b02aff2021714e591.1502211151.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 32 On Tue, Aug 08, 2017 at 10:24:12PM +0530, Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Applied, thank you. > --- > drivers/input/misc/ati_remote2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/misc/ati_remote2.c b/drivers/input/misc/ati_remote2.c > index 1c5914c..ebf4448 100644 > --- a/drivers/input/misc/ati_remote2.c > +++ b/drivers/input/misc/ati_remote2.c > @@ -110,7 +110,7 @@ static const struct kernel_param_ops param_ops_mode_mask = { > module_param(mode_mask, mode_mask, 0644); > MODULE_PARM_DESC(mode_mask, "Bitmask of modes to accept <4:PC><3:AUX4><2:AUX3><1:AUX2><0:AUX1>"); > > -static struct usb_device_id ati_remote2_id_table[] = { > +static const struct usb_device_id ati_remote2_id_table[] = { > { USB_DEVICE(0x0471, 0x0602) }, /* ATI Remote Wonder II */ > { } > }; > -- > 2.7.4 > -- Dmitry