Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753156AbdHOGhO (ORCPT ); Tue, 15 Aug 2017 02:37:14 -0400 Received: from mail-eopbgr20095.outbound.protection.outlook.com ([40.107.2.95]:22656 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752824AbdHOGhL (ORCPT ); Tue, 15 Aug 2017 02:37:11 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [PATCH v5 0/6] drivers/i2c: Add FSI-attached I2C master algorithm To: Eddie James , linux-kernel@vger.kernel.org Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, wsa@the-dreams.de, robh+dt@kernel.org, jk@ozlabs.org, joel@jms.id.au, andrew@aj.id.au, cbostic@linux.vnet.ibm.com, "Edward A. James" References: <1501089198-10356-1-git-send-email-eajames@linux.vnet.ibm.com> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: Date: Tue, 15 Aug 2017 08:36:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501089198-10356-1-git-send-email-eajames@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.168.30] X-ClientProxiedBy: AM5PR0102CA0024.eurprd01.prod.exchangelabs.com (2603:10a6:206::37) To VI1PR0202MB2558.eurprd02.prod.outlook.com (2603:10a6:801:6::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 57817199-d0b8-40c9-37ac-08d4e3a80c86 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(2017082002075)(300000503095)(300135400095)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:VI1PR0202MB2558; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2558;3:qvl0V+rKxxVOQLrT2j/DOaldBgGRG8A+b4sFkGaHMkxogNmI36bYkCfR42RTjz89GLOXzIYEAL5UkDDqkdabqag9kf+vAwrsRLqyxGBE7piEc7V/4jJXsxQBchkWmYMXXxTyziIqidtgJjHiNacaAtwP734YPdgu5Y5J4VLvQiywBaS4scr3zHyERpPSYBO46gn7XpngbBRA0zFGP7dgvrZfAqNnOnzXsVKSMBTKWV3xgKc8asvlLtf9WBum4bew;25:37RSUCWg/JqSgBKhcMi30zJS9kmheCn8EFxVy6xup9VOLqN1UbSd6KmCo3g3hO645QP4gO8zH11REVATOPCfCFB0HHkhU9ZW8WKzKVgWVEyDM/nxU3/ip8HC6HnBwFx/FDRqynPnFD6NyH5BmjmJKN6TSGpPaBxrGV8X+q71rDtwpr0jXUCpug4ZI5ysGfZk+Mt75CSWnLbXUIttmV9lnQqa6w22DRWCrTKZVLLIH0le1W/bbRxCHKkNNCKI/dRvNmJEk6/tIuYYay2/lDIiC6B/JO/oAXRIZlrXmyuGjC4GE28oDIo03Gq+7Wv+w8jO+sRigMiXeoXXVWgK5eZc4Q==;31:Prmu+2N1qoNboiMhXWqsCce/0FJ0iGXKzvo2vOs7NFpXP8CailEVKrAd9PLzU+s5ocVqL2w65StEOkNbW1BLDty+tzjuU2va7JRxIrxyhF/g7axjqiTowH/zbvYYcToBAD3TWrSCvbz0ShNuK9FQsuA6TlX8oBKjH6pMz4dn3Ha+CwogrW8J7uzJC045/vbv07GXxPLmRM+5kt8KEbrYBj0bdIJxungUFaTW9fMnB9Q= X-MS-TrafficTypeDiagnostic: VI1PR0202MB2558: X-Exchange-Antispam-Report-Test: UriScan:(274839183919467)(104084551191319); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6041248)(20161123555025)(2016111802025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(6072148)(6043046)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0202MB2558;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0202MB2558; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2558;4:LzBEtWILQ3IczzB6ei91gXmiAB59sSF/RIi+7l1lrKXbG1YLcviKhxr/k8o8bkATbczp4Bv2tWF/FU0gSiz9+30YqbX2CAq/28JnNDrFyHgnJvCLpf7inToPxbXWH+o2GrVjgtraQ0zMggGhOL1O5jimIjwx9FfA+sLfWzmqGJmbqh1OSngwEdD6wypr99D9BbrFaH3Vr/bDAoAsCMJyjSNhEeZasC9X+90Mr/I1JzgCpVGT7jFb9Wa/A6RnqKOEKVD8oYjjhSU4yRTg2FTuVD17xDEfUicRlyDU2zpMjpb3fHt9puZZzLqSgNQT0s8jN3jJx9xmtI2g717nMQr4xQ== X-Forefront-PRVS: 04004D94E2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(7370300001)(4630300001)(6009001)(6049001)(39830400002)(24454002)(199003)(377424004)(189002)(110136004)(8676002)(33646002)(305945005)(81166006)(81156014)(53936002)(50466002)(189998001)(65956001)(66066001)(7736002)(6246003)(5660300001)(65826007)(31696002)(97736004)(86362001)(3846002)(83506001)(478600001)(6116002)(2906002)(230700001)(4001350100001)(6486002)(76176999)(74482002)(4326008)(101416001)(7416002)(3260700006)(105586002)(31686004)(54356999)(117156002)(50986999)(25786009)(8656003)(47776003)(77096006)(106356001)(7350300001)(23676002)(36756003)(64126003)(68736007)(42186005)(2950100002)(6666003)(229853002)(53546010)(65806001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2558;H:[192.168.13.3];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjAyMDJNQjI1NTg7MjM6ODQ3ZnVNSnB0NDVqSjgrbE5Ta0FMaERZ?= =?utf-8?B?NDFVdEpiTlcrbHdBTG5LOHVBZVA4WFRrVDFsY1ZIYVZudmRjVzZKN3FjQVp5?= =?utf-8?B?clFFWndIdzVYQkxsV2Z3NXdqL0FhVldwQzFmc0Z2dXUrdnpOSXdXZ1FxaWR3?= =?utf-8?B?R1hkZGJCQTVlRDNSQ0pPN3U3RFlTcjZrdzFReXc3ejk4d2xEN3FxcUw1RjAx?= =?utf-8?B?T3U3K3VzZDQyajhHay9mOHc3RkJab0JjcWJteGU4eFJGVTQwdmZwZjYyc25t?= =?utf-8?B?S25sbm1NQnBFeGluR0ljV1JZV0N4L2ZTMlNKK1FBZU1yK3JzTVhpdmN3NTdt?= =?utf-8?B?cFBkRkQ1TVRIb0hYbHdxOEdLTzRLZVVVTFJNREhuenZzR211UndZbmNCaFVz?= =?utf-8?B?QlVnMVJUUEZ2SlVLdHlSTzBBWmw0SW5LdFdSYzRFMFluK2kweVFteHd4bkxo?= =?utf-8?B?U2F5UXFCbGk3eE5iRG1NT1Q4bndURGRUS3AvaU5Va2VuekhyTmhjQjNCZkpk?= =?utf-8?B?OGN3MjhuUUt1ZXlCeFFpNU02eWF4eWk4YnlHN2pudDNmd1VCZSsxZjVyY1Bp?= =?utf-8?B?ZjdTcktWWjN2dnV5WXVodzIyNERVUVZIOGp3MVoycGlaaWpqeWZvcXRENll3?= =?utf-8?B?TmJGcTBKUVEzVlA1akF5a1d4ZHRORER2WmxOOE55eXFwNlpKMExuTng3V1FF?= =?utf-8?B?RDFQdGhMbXFkNlI1dmpOdVR4OXBObDR3QnhnOWJtQzZBaDFHYXNVQmlWTnBO?= =?utf-8?B?Z2Y4a2JpeE9aQkhFOFZNVWFIWDJKUTdVSERXQUdlbmxaUmwxYkM2VG0zWVBX?= =?utf-8?B?OVcwRkhIR3RXOUdnemhiUjNRUTBDT3FxaFc5eVVvNUR3dDg3T2JFZ2RpMGMv?= =?utf-8?B?Z0RQaXg3aHRiRFVhdUY2di9BRkxaS3I4c0lEbExza0IwYjFLblNWSDAxN0Z6?= =?utf-8?B?OFcvSkd1V1Z1c29KVmJTa1FLWGY2REVoRFlDQnVzN1lCZmgrdFgydUc3OHY0?= =?utf-8?B?TkFZVkdkVHdWclVaSHE0UG1sSnU0VldFd3ZTNldLak9nTk0vdVlkRlhGdWJO?= =?utf-8?B?OW0xdlBxaUNRVXV0aHg4VHp3bHJwNHdaQitpV0dXNmRlMmNPWnU2bHgveVBx?= =?utf-8?B?ZlNydWlKdk84S1VpTFdhRFlyT1l0cU0vR1VEY0x2ZlJ0d1pTNnNIZmVtTzkw?= =?utf-8?B?RWduc3pFOVZmVlVqWHhqYXJManVGdVpvYldsd0RLOUdvSThZZ3IrdEovRGVO?= =?utf-8?B?RTBUUVRkT3VaTmRrSXFqNXNnM0IyV29yNHk5U0tIbVNmNnhaN0szUnhiRXhu?= =?utf-8?B?eVoyTzZ6ZWJRMFQ1NGI1RmhPeFdaNXl6ZmEwZHpaTVU2ek51aUYvMlRqYzZ0?= =?utf-8?B?ZlB6VUlnQisrWHBWR2JJRUU4NnFzVUUvL01UQXVBaHdGa1k0b0c0andFVTZx?= =?utf-8?B?VktRSEJtUXJsU29sZ05zSFI0c005aTFybWFJdFI2ZTBRVWpyOTdvV1ZnQ2ww?= =?utf-8?B?TVVsdDBJbDBaNmk2OWlZNmt4YVRXcUYzVStrUTVuZ2VoZnZnb2ZyMGpXMkdK?= =?utf-8?B?N1ltR2M0Q2IxTjVkZDNuR3pqUUtzRGNEYWpOQURkcGpRSFdYeEx5NVVEZnZF?= =?utf-8?B?MTFOZXptR2VpQnp2YzZMcE03amJQODVBZGlBQU40cEpsT2NmcWMyU2VvSzJ4?= =?utf-8?B?c3AySmFZUkZtSGlUY0k4dlVnUU1uMDBZMHplemZjS2FXR1drMVlXOEVQOSt1?= =?utf-8?B?MnVVckNaSWVmZ25GZmRwNnVZVTc2bUtoU2tUS3lyL3l5SUhwWmpDeCtsNmQ0?= =?utf-8?B?bU0vZDNWRzRsWjVrdUpVS0JQMS80Ui9IZnpJamhXN2RQREl5dnErNnlRaitY?= =?utf-8?B?VGlianNlZzY0RDFXM014TUs5NW9GdE5DUHZGTGtXakpnU3U2VHpaODR5Zjg0?= =?utf-8?B?d0JsR1ljeG1meUZhbGo1SEJHTy84SkYra3VRWnlxMzFvaFRBS0hDeHRkRVFi?= =?utf-8?B?TDl0bXYzaWZvN3dQdERiKzlLWEwreWhVZWx4QTMwcy9WYjBIZTluOGppKzNO?= =?utf-8?Q?8q6Wb0=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2558;6:vzbDpT+uK/Fuo24bthe+xzkvbu9u2BSYG4hjK8mOnr4W4cif2lICAssfAPu/dTyLP4aKk5CdPMSjAftm0eclIslJytQ2t12DmPMvtZz6wFv1glTTzjtmuQODV9psctNNT/onI5hnvleZC/3UeFCxDnN7FPleGv9687dYrbtSlUiBQjCcIcsOgxIHsXmiQ3Hc6M3FHPX2G/Siq+OCjyjDa/EFjs2joF48Dy7uizkCp7iF8vgvYOLPAMvdGbHBLS9I9mNw8nyKvy2KzUvH9061gIbwrwcy2iMCVWTjbNzxKpFHNV2Idx8k28Xn9H0T5tHwRE6wZsrwfYl44LIKtzia/g==;5:GVzvTBMRClqy/EyyXIOAdfj+Nrae5njAYRvJZ5HH7sphkcliYv+wzQ78fXhzcQmYTKxNRIQBwklfEIIAX2ifLkmPbExVTFmIS3bTWPPi6roCjjyBWvu0Ebp7+PqaP+33PwguuLceQlx9MNlq7EsZgQ==;24:DS2GCc/5BxRxqKLq4ObsqxseLue65btLxbjmX6pYcJUrHziHTjgzn9edldZFQthAc72Zxl86dxxh2pTqBK0JK45cpEhey/u5JjGbUVlqQoQ=;7:bum0nSNjErVmXKDSUekqROts+C6O5Vi+QwBwTxosnt+VTWWINmH8Ny9Pngni3op6SUOg7D4pZ7FfN1nXAPUPQa5MZFdKnLJACl8QSAyiuq4LjLAQljA1FYE3GW6MQ6IixwYn9ukCHp/B4e95HJX6lls7yyo1XzBepeyr799jWFyqze5iTq3w7uVHDdMkFs3LzdQOFMzz9RtsZ28N8JX32S7uQOUVA6DP5Q7t7ADxw0E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2017 06:37:05.8341 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2558 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 24 On 2017-07-26 19:13, Eddie James wrote: > From: "Edward A. James" > > This series adds an algorithm for an I2C master physically located on an FSI > slave device. The I2C master has multiple ports, each of which may be connected > to an I2C slave. Access to the I2C master registers is achieved over FSI bus. > > Due to the multi-port nature of the I2C master, the driver instantiates a new > I2C adapter for each port connected to a slave. The connected ports should be > defined in the device tree under the I2C master device. Hmmm, AFAIU fsi is a bus, and on this bus you have some "client" device that happens to be an i2c master, and this is a driver for that "client". Is it totally inconceivable to have some other client device in the future that is implementing an i2c master differently, but still using the fsi bus? With that in mind, is it wise to pick the driver name from the bus that the device is connected to, and nothing else without further qualification? I don't see any "i2c-usb" driver, but I think there are a couple of i2c master drivers that communicate via usb. Cheers, Peter