Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753250AbdHOGmg (ORCPT ); Tue, 15 Aug 2017 02:42:36 -0400 Received: from 1.mo2.mail-out.ovh.net ([46.105.63.121]:55991 "EHLO 1.mo2.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbdHOGme (ORCPT ); Tue, 15 Aug 2017 02:42:34 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 15 Aug 2017 08:42:11 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Zhang Rui Cc: Markus Mayer , Eduardo Valentin , Rob Herring , Mark Rutland , Doug Berger , Brian Norris , Gregory Fong , Florian Fainelli , Russell King , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Broadcom Kernel List , Power Management List , Device Tree List , ARM Kernel List , Linux Kernel Mailing List , Markus Mayer Subject: Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver In-Reply-To: <1502777298.2591.1.camel@intel.com> References: <20170809220257.4234-1-code@mmayer.net> <20170809220257.4234-3-code@mmayer.net> <1502777298.2591.1.camel@intel.com> Message-ID: <95da51df3cadbb05f721f2e5b8d59f8d@milecki.pl> User-Agent: Roundcube Webmail/1.3.0 X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl X-Ovh-Tracer-Id: 10941495295306206975 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelkedrleeigdduudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 33 On 2017-08-15 08:08, Zhang Rui wrote: >> diff --git a/drivers/thermal/broadcom/Kconfig >> b/drivers/thermal/broadcom/Kconfig >> index 42c098e..c106a15 100644 >> --- a/drivers/thermal/broadcom/Kconfig >> +++ b/drivers/thermal/broadcom/Kconfig >> @@ -6,6 +6,13 @@ config BCM2835_THERMAL >>   help >>     Support for thermal sensors on Broadcom bcm2835 SoCs. >>   >> +config BRCMSTB_THERMAL >> + tristate "Broadcom STB AVS TMON thermal driver" >> + depends on ARCH_BRCMSTB || COMPILE_TEST >> + help >> +   Enable this driver if you have a Broadcom STB SoC and >> would like >> +   thermal framework support. >> + > > I don't understand why I got the following checkpatch warning > > WARNING: please write a paragraph that describes the config symbol > fully > #73: FILE: drivers/thermal/broadcom/Kconfig:9: > +config BRCMSTB_THERMAL > > I didn't see this for other Kconfig changes. It's because your help message is only 2 lines long (instead of 3). Some (many?) maintainers aren't pedantic about that, a common sense should be applied ;)