Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753624AbdHOGrS (ORCPT ); Tue, 15 Aug 2017 02:47:18 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:34817 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753607AbdHOGrQ (ORCPT ); Tue, 15 Aug 2017 02:47:16 -0400 Date: Mon, 14 Aug 2017 23:47:12 -0700 From: Benson Leung To: Jeffy Chen Cc: bleung@chromium.org, Olof Johansson , linux-kernel@vger.kernel.org, bleung@google.com Subject: Re: [PATCH] platform/chrome: cros_ec_dev - Use devm_mfd_add_devices Message-ID: <20170815064712.GB100591@decatoncale.mtv.corp.google.com> References: <1502104734-32459-1-git-send-email-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kXdP64Ggrk/fb43R" Content-Disposition: inline In-Reply-To: <1502104734-32459-1-git-send-email-jeffy.chen@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2189 Lines: 68 --kXdP64Ggrk/fb43R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Jeffy, On Mon, Aug 07, 2017 at 07:18:54PM +0800, Jeffy Chen wrote: > Currently we are calling mfd_add_devices to add devices without matched > mfd_remove_devices to remove them. >=20 > That would cause warning when re-binding cros_ec_dev: >=20 > [ 123.536192] sysfs: cannot create duplicate filename '/bus/platform/dev= ices/cros- > ec-accel.0' > [ 123.536210] ------------[ cut here ]------------ > [ 123.536223] WARNING: CPU: 3 PID: 156 at fs/sysfs/dir.c:31 sysfs_warn_d= up+0x68/0x > 84 > [ 123.536226] Modules linked in: > [ 123.536236] CPU: 3 PID: 156 Comm: bash Not tainted 4.13.0-rc3-next-201= 70731 #216 > [ 123.536238] Hardware name: Google Kevin (DT) > [ 123.536242] task: ffffffc0f28bab80 task.stack: ffffffc0f1b30000 > [ 123.536247] PC is at sysfs_warn_dup+0x68/0x84 > [ 123.536251] LR is at sysfs_warn_dup+0x68/0x84 >=20 > Signed-off-by: Jeffy Chen Thanks for the fix. Applied for v4.14. Thanks, Benson --=20 Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org --kXdP64Ggrk/fb43R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJZkpjwAAoJEB8J9XsKL+ZYGdUP/3uw7kKxq1Bp8R7dUsQrLQ0W TmNJFXGM8S46V4cglno/B5f7c9g24mcOR47+0+Rr/336MyexFH9BVp1Hcc65B5HC eu/NVbhEfDioeSHFqgfEi9EMMJgvij3IGfavgNGs9nma2Nhh8UEg4yFsihuuVGrS HGslRJhMNMdcDXmthF8gyDULM9srdBUne0+3GF5oAQScXHr0HcTfYNH8uErGYn1q GrcPb1sM65MLc9FD33uZnMjJOD98V4+hItTAtSEw8vScvSDVxl3Y0pewmsyGwa8Z EZh2/BFhj/5vO+I5uF5noTu+JhiSRckcjDZ3yjvum4yiWE4Gfj97xgYtKvSAkrbZ gjJ15hsT0ZH/Aaa8ZuH9ecZ5PG/FDy9Gfb9ZJV5MYE+65LXXhdfLm0OvljCK9i9G nPR1WmuCMCSdy0FV+B5to8DSCZkzngrAvfvV+ZYLBaEw1IcxPM/rZIQN2IJov9d9 7uneR1RhOswclq/f+X2GfAreWbjNYY7145VShCcJRUCyKxXtYTUGamN54M2lps+Z EtTLc1CIN09wKMR+JuSkrz0COVCzZKOOd3JnV2l/1YnNUx6eppTbeEBHOjCULB6o mZ47PeS3QVNFrXoJ3WUn/fwXk2BdnWVZu2SVBviu6WTPjOVFrUKe8yQx777wpgxj 70wXIQyS00tfZP1LA5Q6 =xytf -----END PGP SIGNATURE----- --kXdP64Ggrk/fb43R--