Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753377AbdHOJBe (ORCPT ); Tue, 15 Aug 2017 05:01:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:39038 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752105AbdHOJBW (ORCPT ); Tue, 15 Aug 2017 05:01:22 -0400 Date: Tue, 15 Aug 2017 11:01:20 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Arvind Yadav cc: jic23@kernel.org, srinivas.pandruvada@linux.intel.com, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] HID: sensor: constify platform_device_id In-Reply-To: <2ae0f9137a673466f09a9d5169c9ef13bbe66a30.1502617403.git.arvind.yadav.cs@gmail.com> Message-ID: References: <2ae0f9137a673466f09a9d5169c9ef13bbe66a30.1502617403.git.arvind.yadav.cs@gmail.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 31 On Sun, 13 Aug 2017, Arvind Yadav wrote: > platform_device_id are not supposed to change at runtime. All functions > working with platform_device_id provided by > work with const platform_device_id. So mark the non-const structs as > const. > > Signed-off-by: Arvind Yadav > --- > drivers/hid/hid-sensor-custom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c > index 3a84aaf..5ad39fd 100644 > --- a/drivers/hid/hid-sensor-custom.c > +++ b/drivers/hid/hid-sensor-custom.c > @@ -823,7 +823,7 @@ static int hid_sensor_custom_remove(struct platform_device *pdev) > return 0; > } > > -static struct platform_device_id hid_sensor_custom_ids[] = { > +static const struct platform_device_id hid_sensor_custom_ids[] = { > { > .name = "HID-SENSOR-2000e1", > }, Applied to for-4.14/ish. -- Jiri Kosina SUSE Labs