Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752250AbdHOLKb (ORCPT ); Tue, 15 Aug 2017 07:10:31 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:36420 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbdHOLK3 (ORCPT ); Tue, 15 Aug 2017 07:10:29 -0400 MIME-Version: 1.0 In-Reply-To: <87h8x96tth.fsf@linux.intel.com> References: <87h8x96tth.fsf@linux.intel.com> From: Baolin Wang Date: Tue, 15 Aug 2017 19:10:28 +0800 Message-ID: Subject: Re: [PATCH v4 0/3] Introduce USB charger support in USB phy To: Felipe Balbi Cc: Greg KH , Sebastian Reichel , Lee Jones , Rob Herring , Mark Rutland , Jun Li , Peter Chen , Mark Brown , John Stultz , NeilBrown , patches@opensource.wolfsonmicro.com, Linux PM list , USB , device-mainlining@lists.linuxfoundation.org, LKML , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 41 Hi Felipe, On 15 August 2017 at 17:53, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>> Currently the Linux kernel does not provide any standard integration of this >>> feature that integrates the USB subsystem with the system power regulation >>> provided by PMICs meaning that either vendors must add this in their kernels >>> or USB gadget devices based on Linux (such as mobile phones) may not behave >>> as they should. Thus provide a standard USB charger support in USB phy core >>> for doing this in kernel. >>> >>> Now introduce one user with wm831x_power to support and test the usb charger. >>> In future we will also cnvert below power drivers: >>> drivers/power/supply/axp288_charger.c >>> drivers/power/supply/bq24190_charger.c >>> drivers/power/supply/charger-manager.c >>> drivers/power/supply/qcom_smbb.c >>> >>> Changes since v3: >>> - Bail out errors when failed to find usb phy for wm831x_power driver. >>> Changes since v2: >>> - Add DT binding documentation for wm831x_power driver. >>> - Change 'usb-phy' as one optional property for wm831x_power driver. >>> Changes since v1: >>> - Fix building errors. >> >> Do you have any comments about usb charger support in usb phy core? Thanks. > > No more comments from me Thanks for your feedback. I've send out V5 patchset which just changes phy phandle name from 'usb-phy' to 'phys' for patch 3 suggested by Rob. Hope you can apply this version patchset into your branch if there are no other comments. -- Baolin.wang Best Regards