Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751882AbdHOLMB (ORCPT <rfc822;w@1wt.eu>);
        Tue, 15 Aug 2017 07:12:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39502 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750950AbdHOLMA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Aug 2017 07:12:00 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BD721432A4
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=cohuck@redhat.com
Date: Tue, 15 Aug 2017 13:11:55 +0200
From: Cornelia Huck <cohuck@redhat.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
        sth@linux.vnet.ibm.com, hoeppner@linux.vnet.ibm.com,
        jwi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com,
        maier@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [RFT 13/13] s390: virtio: constify ccw_device_id
Message-ID: <20170815131155.4156a71d.cohuck@redhat.com>
In-Reply-To: <1502793344-5368-14-git-send-email-arvind.yadav.cs@gmail.com>
References: <1502793344-5368-1-git-send-email-arvind.yadav.cs@gmail.com>
        <1502793344-5368-14-git-send-email-arvind.yadav.cs@gmail.com>
Organization: Red Hat GmbH
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 15 Aug 2017 11:12:00 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 950
Lines: 27

On Tue, 15 Aug 2017 16:05:44 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> ccw_device_id are not supposed to change at runtime. All functions
> working with ccw_device_id provided by <asm/ccwdev.h> work with
> const ccw_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/s390/virtio/virtio_ccw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
> index b18fe20..b43dbba 100644
> --- a/drivers/s390/virtio/virtio_ccw.c
> +++ b/drivers/s390/virtio/virtio_ccw.c
> @@ -1307,7 +1307,7 @@ static int virtio_ccw_cio_notify(struct ccw_device *cdev, int event)
>  	return rc;
>  }
>  
> -static struct ccw_device_id virtio_ids[] = {
> +static const struct ccw_device_id virtio_ids[] = {
>  	{ CCW_DEVICE(0x3832, 0) },
>  	{},
>  };

Acked-by: Cornelia Huck <cohuck@redhat.com>