Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752273AbdHOLax (ORCPT ); Tue, 15 Aug 2017 07:30:53 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57292 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752021AbdHOLav (ORCPT ); Tue, 15 Aug 2017 07:30:51 -0400 Date: Tue, 15 Aug 2017 13:30:44 +0200 From: Heiko Carstens To: Arvind Yadav Cc: schwidefsky@de.ibm.com, sth@linux.vnet.ibm.com, hoeppner@linux.vnet.ibm.com, jwi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com, maier@linux.vnet.ibm.com, cohuck@redhat.com, pasic@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [RFT 00/13] constify s390 ccw_device_id References: <1502793344-5368-1-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502793344-5368-1-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 17081511-0020-0000-0000-000003AEDB3B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17081511-0021-0000-0000-0000423DC012 Message-Id: <20170815113044.GC3552@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-15_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1708150195 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 24 On Tue, Aug 15, 2017 at 04:05:31PM +0530, Arvind Yadav wrote: > ccw_device_id are not supposed to change at runtime. All functions > working with ccw_device_id provided by work with > const ccw_device_id. So mark ccw_device_id member of struct ccw driver > as const. And change all driver relatively. > > Arvind Yadav (13): > [RFT 01/13] s390: ccwdev: constify ccw_device_id > [RFT 02/13] s390: dasd_eckd: constify ccw_device_id > [RFT 03/13] s390: dasd_fba: constify ccw_device_id > [RFT 04/13] s390: con3215: constify ccw_device_id > [RFT 05/13] s390: raw3270: constify ccw_device_id > [RFT 06/13] s390: tape_34xx: constify ccw_device_id > [RFT 07/13] s390: tape_3590: constify ccw_device_id > [RFT 08/13] s390: vmur: constify ccw_device_id > [RFT 09/13] s390: ctcm: constify ccw_device_id > [RFT 10/13] s390: lcs: constify ccw_device_id > [RFT 11/13] s390: qeth: constify ccw_device_id > [RFT 12/13] s390: zfcp: constify ccw_device_id > [RFT 13/13] s390: virtio: constify ccw_device_id Did the constify work reveal a single bug until now? This causes a lot of code churn, and I'm failing to see an added value here. In addition this is not worth splitting it into 13(!) patches.