Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752337AbdHOMK1 (ORCPT ); Tue, 15 Aug 2017 08:10:27 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3537 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472AbdHOMKZ (ORCPT ); Tue, 15 Aug 2017 08:10:25 -0400 Subject: Re: [PATCH v2] f2fs-tools: fix the usage message of overprovision option To: Yunlong Song , , , CC: , , , , References: <1502457915-46935-1-git-send-email-yunlong.song@huawei.com> <1502782917-97779-1-git-send-email-yunlong.song@huawei.com> From: Chao Yu Message-ID: <4f0395b6-82a6-e009-0332-f64b197ceb43@huawei.com> Date: Tue, 15 Aug 2017 20:09:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502782917-97779-1-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.5992E498.0110,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: f139a48fc64d783376cd81d03db276b3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 27 On 2017/8/15 15:41, Yunlong Song wrote: > The usage message shows a wrong message for ovp option, so fix it. > > Signed-off-by: Yunlong Song > --- > mkfs/f2fs_format_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c > index a3652a9..3279829 100644 > --- a/mkfs/f2fs_format_main.c > +++ b/mkfs/f2fs_format_main.c > @@ -41,7 +41,7 @@ static void mkfs_usage() > MSG(0, " -f force overwrite the exist filesystem\n"); > MSG(0, " -l label\n"); > MSG(0, " -m support zoned block device [default:0]\n"); > - MSG(0, " -o overprovision ratio [default:5]\n"); > + MSG(0, " -o overprovision ratio [initial value 0 lets mkfs determine its best value]\n"); [mkfs decides, the value trends to maximize user visible space] ? Thanks, > MSG(0, " -O [feature list] e.g. \"encrypt\"\n"); > MSG(0, " -q quiet mode\n"); > MSG(0, " -s # of segments per section [default:1]\n"); >