DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 442F27AEA7
Date: Tue, 15 Aug 2017 14:11:20 +0200
From: Miroslav Lichvar <mlichvar@redhat.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
        Shuah Khan <shuahkh@osg.samsung.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@codeaurora.org>, linux-kselftest@vger.kernel.org
Subject: Re: [RFC][PATCH 2/2] selftests: timers: freq-step: Fix build warning
Message-ID: <20170815121120.GB8800@localhost>
References: <1502744496-17863-1-git-send-email-john.stultz@linaro.org>
 <1502744496-17863-2-git-send-email-john.stultz@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1502744496-17863-2-git-send-email-john.stultz@linaro.org>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 551
Lines: 22

On Mon, Aug 14, 2017 at 02:01:36PM -0700, John Stultz wrote:
> Fixes the following build warning:
> freq-step.c: In function ‘main’:
> freq-step.c:271:1: warning: control reaches end of non-void function [-Wreturn-type]

> @@ -268,4 +268,6 @@ int main(int argc, char **argv)
>  		ksft_exit_fail();
>  
>  	ksft_exit_pass();
> +
> +	return 0;
>  }

It seems most tests use "return ksft_exit_pass();". Would that be
preferred over separate return? I don't have a preference.

Both patches in this set look good to me.

Thanks,

-- 
Miroslav Lichvar