Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751653AbdHONvs (ORCPT ); Tue, 15 Aug 2017 09:51:48 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:52954 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750950AbdHONvq (ORCPT ); Tue, 15 Aug 2017 09:51:46 -0400 Message-ID: <1502805100.25910.8.camel@mtkswgap22> Subject: Re: [PATCH] ASoC: mediatek: Correct the interrupt property From: Ryder Lee To: Mark Brown CC: , , , , Garlic Tseng Date: Tue, 15 Aug 2017 21:51:40 +0800 In-Reply-To: <20170815115309.glj52jx3kpq4jxq3@sirena.org.uk> References: <43a7fb98e7252d0b7b73cdabf1eedd0bf896d68c.1502784169.git.ryder.lee@mediatek.com> <20170815115309.glj52jx3kpq4jxq3@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 19 On Tue, 2017-08-15 at 12:53 +0100, Mark Brown wrote: > On Tue, Aug 15, 2017 at 04:07:02PM +0800, Ryder Lee wrote: > > > This patch update interrupt property since we only use ASYS IRQ > > in the driver, and this may confuse people. > > > - interrupts = , > > - ; > > + interrupts = ; > > What harm does having the extra information in the bindings do? If it's > possible there might be a use for the extra interrupt it seems better to > have people describe it. Yes you're right. The current driver get IRQ number by index "0" but actually it should be "1" (GIC 132). Perhaps we can switch to use the platform_get_irq_byname() and add interrupt-name in DT so that binding can be agnostic of the IRQ order.