Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751855AbdHONv7 (ORCPT ); Tue, 15 Aug 2017 09:51:59 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:38762 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751797AbdHONv5 (ORCPT ); Tue, 15 Aug 2017 09:51:57 -0400 Date: Tue, 15 Aug 2017 09:51:55 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Colin King cc: Felipe Balbi , Greg Kroah-Hartman , Peter Chen , Johan Hovold , Yuyang Du , , , Subject: Re: [PATCH] usb: gadget: dummy: fix infinite loop because of missing loop decrement In-Reply-To: <20170815073845.18880-1-colin.king@canonical.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 29 On Tue, 15 Aug 2017, Colin King wrote: > From: Colin Ian King > > The while loop never terminates because the loop counter i is never > decremented. Fix this by decrementing i. > > Detected by CoverityScan, CID#751073 ("Infinite Loop") > > Signed-off-by: Colin Ian King > --- > drivers/usb/gadget/udc/dummy_hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c > index 3c3760315910..a030d7923d7d 100644 > --- a/drivers/usb/gadget/udc/dummy_hcd.c > +++ b/drivers/usb/gadget/udc/dummy_hcd.c > @@ -2776,7 +2776,7 @@ static int __init init(void) > if (retval < 0) { > i--; > while (i >= 0) > - platform_device_del(the_udc_pdev[i]); > + platform_device_del(the_udc_pdev[i--]); > goto err_add_udc; > } > } Acked-by: Alan Stern