Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751576AbdHOPh5 (ORCPT ); Tue, 15 Aug 2017 11:37:57 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33900 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412AbdHOPhw (ORCPT ); Tue, 15 Aug 2017 11:37:52 -0400 Message-ID: <1502811469.4936.84.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH v2] sctp: fully initialize the IPv6 address in sctp_v6_to_addr() From: Eric Dumazet To: Marcelo Ricardo Leitner Cc: David Miller , hideaki.yoshifuji@miraclelinux.com, glider@google.com, dvyukov@google.com, kcc@google.com, edumazet@google.com, lucien.xin@gmail.com, vyasevich@gmail.com, linux-kernel@vger.kernel.org, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org Date: Tue, 15 Aug 2017 08:37:49 -0700 In-Reply-To: <20170815150557.GC18688@localhost.localdomain> References: <20170814184304.82747-1-glider@google.com> <20170815015814.GB18688@localhost.localdomain> <20170814.194051.1408830683580606508.davem@davemloft.net> <20170815150557.GC18688@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 317 Lines: 11 On Tue, 2017-08-15 at 12:05 -0300, Marcelo Ricardo Leitner wrote: > Ok, but I should see a difference in the generated code, right? Depends on the compiler. Have you tried older versions ? One argument is that following struct member definition eases code review. (It is easier to catch a field init is missing)