Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753824AbdHORaF (ORCPT ); Tue, 15 Aug 2017 13:30:05 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33517 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753677AbdHORaE (ORCPT ); Tue, 15 Aug 2017 13:30:04 -0400 Date: Tue, 15 Aug 2017 19:29:58 +0200 From: Krzysztof Kozlowski To: Anton Vasilyev Cc: Sylwester Nawrocki , Sangbeom Kim , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH v4] ASoC: samsung: i2s: Null pointer dereference on samsung_i2s_remove Message-ID: <20170815172958.q2kd75w2p2seypsa@kozik-lap> References: <1502799594-596-1-git-send-email-vasilyev@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1502799594-596-1-git-send-email-vasilyev@ispras.ru> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 27 On Tue, Aug 15, 2017 at 03:19:54PM +0300, Anton Vasilyev wrote: > If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate > sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove() > performs pri_dai->sec_dai dereference in any case. > > The patch removes useless reinitialization of sec_dai at > samsung_i2s_remove(), because resources are under devm control. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Anton Vasilyev > --- > v2: Drop initialization of sec_dai by NULL at samsung_i2s_remove > as Sylwester Nawrocki suggest. > --- > v3: Fix typo in the comment > --- > v4: Change comment based on Krzysztof review. > --- > sound/soc/samsung/i2s.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof