Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752815AbdHOWm4 (ORCPT ); Tue, 15 Aug 2017 18:42:56 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:57803 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbdHOWmx (ORCPT ); Tue, 15 Aug 2017 18:42:53 -0400 Date: Tue, 15 Aug 2017 15:42:50 -0700 From: Darren Hart To: Andy Shevchenko Cc: Hao Wei Tee , Platform Driver , "linux-kernel@vger.kernel.org" , Andy Shevchenko , Ike Panhc Subject: Re: [PATCH v2] platform/x86: ideapad-laptop: Expose conservation mode switch Message-ID: <20170815224250.GA28337@fury> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 24 On Mon, Aug 14, 2017 at 06:32:48PM +0300, Andy Shevchenko wrote: > On Mon, Aug 14, 2017 at 5:17 PM, Hao Wei Tee wrote: > > +static int method_gbmd(acpi_handle handle, unsigned long *ret) > > +{ > > + int val; > > + int result = read_method_int(handle, "GBMD", &val); > > Reversed X-mas tree order in new code, please. Generally yes, but of here they are using &val in the second initializer. So either as is or: int result; int val; result = read_method_int(handle, "GBMD", &val) I tend to accept it as is when there is a declaration order dependency like this. -- Darren Hart VMware Open Source Technology Center